Interface icx_getorder RPC
#401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surangap
requested review from
canonbrother,
fuxingloh,
jingyi2811,
monstrobishi and
thedoublejay
as code owners
surangap
force-pushed
the
surangap/icx-closeoffer
branch
from
3118918 to
f712ce8
Compare
surangap
force-pushed
the
surangap/icx-getorder
branch
from
cd8d2c5 to
3c57adb
Compare
surangap
force-pushed
the
surangap/icx-closeoffer
branch
from
f712ce8 to
0c224ff
Compare
30 tasks
surangap
force-pushed
the
surangap/icx-closeoffer
branch
2 times, most recently
from
75a63c5 to
ca3ef5a
Compare
surangap
force-pushed
the
surangap/icx-getorder
branch
from
3c57adb to
7f3c9eb
Compare
surangap
force-pushed
the
surangap/icx-getorder
branch
from
7f3c9eb to
40f7070
Compare
|
Code Climate has analyzed commit 40f7070 and detected 0 issues on this pull request. View more on Code Climate. |
|
✔️ Deploy Preview for jellyfish-defi ready! 🔨 Explore the source changes: 40f7070 🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/60dc4de9c64692000795a104 😎 Browse the preview: https://deploy-preview-401--jellyfish-defi.netlify.app |
surangap
commented
Jun 30, 2021
packages/jellyfish-api-core/__tests__/category/icxorderbook/getOrder.test.ts
Show resolved
Hide resolved
surangap
commented
Jun 30, 2021
packages/jellyfish-api-core/__tests__/category/icxorderbook/getOrder.test.ts
Show resolved
Hide resolved
size-limit report 📦
|
canonbrother
approved these changes
Jun 30, 2021
Codecov Report
@@ Coverage Diff @@
## main #401 +/- ##
=======================================
Coverage 97.33% 97.33%
=======================================
Files 96 96
Lines 2814 2816 +2
Branches 285 285
=======================================
+ Hits 2739 2741 +2
Misses 75 75
Continue to review full report at Codecov.
|
fuxingloh
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of PR is this?:
/kind feature
What this PR does / why we need it:
This PR will interface
icx_getorderRPC to jellyfishWhich issue(s) does this PR fixes?:
Fixes #
Additional comments?:
depends on #400