Interface icx_submitdfchtlc RPC
#404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surangap
force-pushed
the
surangap/icx-submitdfchtlc
branch
from
92e1b51 to
6cac7de
Compare
surangap
changed the title
icx_submitexthtlc RPCicx_submitdfchtlc RPC
surangap
commented
Jun 22, 2021
packages/jellyfish-api-core/__tests__/category/icxorderbook/submitDFCHTLC.test.ts
Outdated
Show resolved
Hide resolved
surangap
commented
Jun 22, 2021
packages/jellyfish-api-core/__tests__/category/icxorderbook/submitDFCHTLC.test.ts
Show resolved
Hide resolved
surangap
requested review from
canonbrother,
fuxingloh,
jingyi2811,
monstrobishi and
thedoublejay
as code owners
surangap
force-pushed
the
surangap/icx-listorders
branch
from
440bb01 to
b9a0805
Compare
surangap
force-pushed
the
surangap/icx-submitdfchtlc
branch
from
6cac7de to
2f6acbd
Compare
30 tasks
surangap
force-pushed
the
surangap/icx-listorders
branch
from
b9a0805 to
a698813
Compare
surangap
force-pushed
the
surangap/icx-listorders
branch
2 times, most recently
from
64723ac to
c7e11ac
Compare
surangap
force-pushed
the
surangap/icx-submitdfchtlc
branch
from
2f6acbd to
79a3362
Compare
|
Code Climate has analyzed commit e4dcfc8 and detected 0 issues on this pull request. View more on Code Climate. |
|
✔️ Deploy Preview for jellyfish-defi ready! 🔨 Explore the source changes: 79a3362 🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/60e29708d622460008107da9 😎 Browse the preview: https://deploy-preview-404--jellyfish-defi.netlify.app |
size-limit report 📦
|
surangap
commented
Jul 5, 2021
canonbrother
reviewed
Jul 5, 2021
canonbrother
reviewed
Jul 5, 2021
canonbrother
requested changes
Jul 5, 2021
packages/jellyfish-api-core/__tests__/category/icxorderbook/submitDFCHTLC.test.ts
Outdated
Show resolved
Hide resolved
canonbrother
reviewed
Jul 5, 2021
packages/jellyfish-api-core/__tests__/category/icxorderbook/submitDFCHTLC.test.ts
Outdated
Show resolved
Hide resolved
canonbrother
reviewed
Jul 5, 2021
fuxingloh
suggested changes
Jul 5, 2021
packages/jellyfish-api-core/__tests__/category/icxorderbook/submitDFCHTLC.test.ts
Show resolved
Hide resolved
packages/jellyfish-api-core/__tests__/category/icxorderbook/submitDFCHTLC.test.ts
Outdated
Show resolved
Hide resolved
packages/jellyfish-api-core/__tests__/category/icxorderbook/submitDFCHTLC.test.ts
Show resolved
Hide resolved
packages/jellyfish-api-core/__tests__/category/icxorderbook/submitDFCHTLC.test.ts
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #404 +/- ##
==========================================
+ Coverage 97.36% 97.40% +0.04%
==========================================
Files 96 98 +2
Lines 2841 2893 +52
Branches 285 285
==========================================
+ Hits 2766 2818 +52
Misses 75 75
Continue to review full report at Codecov.
|
fuxingloh
approved these changes
Jul 6, 2021
packages/jellyfish-api-core/__tests__/category/icxorderbook/closeOffer.test.ts
Show resolved
Hide resolved
canonbrother
approved these changes
Jul 6, 2021
eli-lim
pushed a commit
that referenced
this pull request
Mar 27, 2022
* Added block difficulty to stat endpoint * Improved code * Applied changes from code review * Fixed tests failur] * Updated code per code review * Improved code based on code review
canonbrother
pushed a commit
that referenced
this pull request
Jun 1, 2022
* Added block difficulty to stat endpoint * Improved code * Applied changes from code review * Fixed tests failur] * Updated code per code review * Improved code based on code review
canonbrother
pushed a commit
that referenced
this pull request
Jun 1, 2022
* Added block difficulty to stat endpoint * Improved code * Applied changes from code review * Fixed tests failur] * Updated code per code review * Improved code based on code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of PR is this?:
/kind feature
What this PR does / why we need it:
This PR will interface
icx_submitdfchtlcRPC to jellyfishWhich issue(s) does this PR fixes?:
Fixes #
Additional comments?:
depends on #402