-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added SPV createHtlc RPC #511
Conversation
Code Climate has analyzed commit 9abc8da and detected 0 issues on this pull request. View more on Code Climate. |
✔️ Deploy Preview for jellyfish-defi ready! 🔨 Explore the source changes: 3f4944c 🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/6107aef925504000077e144a 😎 Browse the preview: https://deploy-preview-511--jellyfish-defi.netlify.app |
4db4adb
to
21c39c7
Compare
size-limit report 📦
|
Codecov Report
@@ Coverage Diff @@
## main #511 +/- ##
==========================================
- Coverage 97.45% 97.36% -0.09%
==========================================
Files 109 112 +3
Lines 3222 3305 +83
Branches 393 409 +16
==========================================
+ Hits 3140 3218 +78
- Misses 82 87 +5
Continue to review full report at Codecov.
|
packages/jellyfish-api-core/__tests__/category/spv/createHtlc.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall good for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Request to add some more tests and docs changes
… seed/seedhash are not returned in CreateHtlcResult. Set the properties as optional accordingly
…yfish into jouzo/spv_createhtlc
What kind of PR is this?:
/kind feature
What this PR does / why we need it:
Adds SPV createHtlc RPC
Which issue(s) does this PR fixes?:
Fixes part of #202