Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SPV createHtlc RPC #511

Merged
merged 7 commits into from
Aug 2, 2021
Merged

Added SPV createHtlc RPC #511

merged 7 commits into from
Aug 2, 2021

Conversation

Jouzo
Copy link
Contributor

@Jouzo Jouzo commented Jul 28, 2021

What kind of PR is this?:

/kind feature

What this PR does / why we need it:

Adds SPV createHtlc RPC

Which issue(s) does this PR fixes?:

Fixes part of #202

@codeclimate
Copy link

codeclimate bot commented Jul 28, 2021

Code Climate has analyzed commit 9abc8da and detected 0 issues on this pull request.

View more on Code Climate.

@netlify
Copy link

netlify bot commented Jul 28, 2021

✔️ Deploy Preview for jellyfish-defi ready!

🔨 Explore the source changes: 3f4944c

🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/6107aef925504000077e144a

😎 Browse the preview: https://deploy-preview-511--jellyfish-defi.netlify.app

@Jouzo Jouzo mentioned this pull request Jul 28, 2021
30 tasks
@Jouzo Jouzo marked this pull request as ready for review July 30, 2021 12:48
@github-actions
Copy link

github-actions bot commented Jul 30, 2021

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/jellyfish/dist/index.umd.js 22.29 KB (+0.26% 🔺) 446 ms (+0.26% 🔺) 189 ms (+0.28% 🔺) 634 ms

@codecov
Copy link

codecov bot commented Jul 30, 2021

Codecov Report

Merging #511 (9abc8da) into main (50b153f) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #511      +/-   ##
==========================================
- Coverage   97.45%   97.36%   -0.09%     
==========================================
  Files         109      112       +3     
  Lines        3222     3305      +83     
  Branches      393      409      +16     
==========================================
+ Hits         3140     3218      +78     
- Misses         82       87       +5     
Impacted Files Coverage Δ
packages/jellyfish-api-core/src/category/spv.ts 100.00% <100.00%> (ø)
...ages/testcontainers/src/chains/docker_container.ts 95.34% <0.00%> (-4.66%) ⬇️
...kages/testcontainers/src/chains/defid_container.ts 91.83% <0.00%> (-0.80%) ⬇️
packages/testcontainers/src/index.ts 100.00% <0.00%> (ø)
...ainers/src/chains/reg_test_container/masternode.ts 83.92% <0.00%> (ø)
...kages/jellyfish-wallet-encrypted/src/encryption.ts 93.75% <0.00%> (ø)
packages/testcontainers/src/wait_for_condition.ts 100.00% <0.00%> (ø)
.../src/chains/reg_test_container/masternode_group.ts 94.59% <0.00%> (ø)
packages/jellyfish-wallet-encrypted/src/scrypt.ts 100.00% <0.00%> (+6.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50b153f...9abc8da. Read the comment docs.

Copy link
Contributor

@canonbrother canonbrother left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall good for me

Copy link
Contributor

@surangap surangap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request to add some more tests and docs changes

Jouzo added 3 commits August 2, 2021 09:58
@Jouzo Jouzo requested a review from surangap August 2, 2021 08:43
@Jouzo Jouzo requested a review from canonbrother August 2, 2021 08:46
@fuxingloh fuxingloh merged commit d283bd5 into main Aug 2, 2021
@fuxingloh fuxingloh deleted the jouzo/spv_createhtlc branch August 2, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants