Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add appointOracle RPC #336

Merged
merged 7 commits into from
Jun 3, 2021
Merged

Add appointOracle RPC #336

merged 7 commits into from
Jun 3, 2021

Conversation

jingyi2811
Copy link
Contributor

@jingyi2811 jingyi2811 commented Jun 2, 2021 •
edited by fuxingloh
Loading

What kind of PR is this?:

/kind feature

What this PR does / why we need it:

Add appointoracle rpc

Which issue(s) does this PR fixes?:

Fixes part of #202

Additional comments?:

@jingyi2811 jingyi2811 marked this pull request as draft June 2, 2021 14:51
@jingyi2811 jingyi2811 mentioned this pull request Jun 2, 2021
Closed
30 tasks
@netlify
Copy link

netlify bot commented Jun 2, 2021 •
edited
Loading

✔️ Deploy Preview for jellyfish-defi ready!

🔨 Explore the source changes: 53942ca

🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/60b858c29535ec0008e92c71

😎 Browse the preview: https://deploy-preview-336--jellyfish-defi.netlify.app

@github-actions
Copy link

github-actions bot commented Jun 2, 2021 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/jellyfish/dist/jellyfish.umd.js 19.88 KB (+0.69% 🔺) 398 ms (+0.69% 🔺) 175 ms (+0.9% 🔺) 573 ms

@codeclimate
Copy link

codeclimate bot commented Jun 2, 2021 •
edited
Loading

Code Climate has analyzed commit e8e0086 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Jun 2, 2021 •
edited
Loading

Codecov Report

Merging #336 (e8e0086) into main (116bcdb) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #336      +/-   ##
==========================================
+ Coverage   97.06%   97.07%   +0.01%     
==========================================
  Files          92       93       +1     
  Lines        2589     2598       +9     
  Branches      329      331       +2     
==========================================
+ Hits         2513     2522       +9     
  Misses         76       76
Impacted Files Coverage Δ
packages/jellyfish-api-core/src/category/oracle.ts 100.00% <100.00%> (ø)
packages/jellyfish-api-core/src/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 116bcdb...e8e0086. Read the comment docs.

@jingyi2811 jingyi2811 marked this pull request as ready for review June 3, 2021 04:39
@jingyi2811 jingyi2811 requested a review from surangap as a code owner June 3, 2021 04:39
monstrobishi
monstrobishi previously approved these changes Jun 3, 2021
View reviewed changes
@jingyi2811
Copy link
Contributor Author

Ahmed has approved this PR. But I remove the wrong comments after that.

fuxingloh
fuxingloh approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@fuxingloh fuxingloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should test a few more edge conditions, I will merge first since I can see you wan to avoid conflicts as you have many staged commits.

packages/jellyfish-api-core/src/category/oracle.ts
* @param {UTXO[]} [options.utxos = []]
* @param {string} [options.utxos.txid]
* @param {number} [options.utxos.vout]
* @return {Promise<string>}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should document that what is return is actually an txid

packages/jellyfish-api-core/__tests__/category/oracle/appointOracle.test.ts Show resolved Hide resolved
packages/jellyfish-api-core/__tests__/category/oracle/appointOracle.test.ts
Comment on lines +50 to +51
{ currency: 'USD', token: 'TESLA' },
{ currency: 'EUR', token: 'APPLE' }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should test anomalous text length, e.g. 1 char, 15 char

@fuxingloh fuxingloh changed the title Add appointoracle rpc Add appointOracle RPC Jun 3, 2021
@fuxingloh fuxingloh merged commit 1799844 into main Jun 3, 2021
@fuxingloh fuxingloh deleted the jimmy/appointoracle branch June 3, 2021 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuxingloh fuxingloh fuxingloh approved these changes

@monstrobishi monstrobishi monstrobishi left review comments

@canonbrother canonbrother Awaiting requested review from canonbrother canonbrother is a code owner

@thedoublejay thedoublejay Awaiting requested review from thedoublejay

@surangap surangap Awaiting requested review from surangap

Assignees

@jingyi2811 jingyi2811

Labels
kind/feature New feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jingyi2811 @monstrobishi @fuxingloh @defichain-bot