Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface icx_listhtlcs RPC #407

Merged
merged 4 commits into from
Jul 12, 2021
Merged

Interface icx_listhtlcs RPC #407

merged 4 commits into from
Jul 12, 2021

Conversation

surangap
Copy link
Contributor

What kind of PR is this?:

/kind feature

What this PR does / why we need it:

This PR will interfaceicx_listhtlcs RPC to jellyfish

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

depends on #406

@surangap surangap marked this pull request as ready for review June 22, 2021 06:24
@surangap surangap force-pushed the surangap/icx-claimdfchtlc branch from 2917361 to e4360f1 Compare June 23, 2021 16:48
@surangap surangap force-pushed the surangap/icx-listhtlcs branch from e55ea71 to 9d285a6 Compare June 23, 2021 16:48
@surangap surangap mentioned this pull request Jun 29, 2021
30 tasks
@surangap surangap force-pushed the surangap/icx-claimdfchtlc branch from e4360f1 to 60b191d Compare July 7, 2021 06:22
@surangap surangap force-pushed the surangap/icx-claimdfchtlc branch 2 times, most recently from f6dbc5a to 51a05be Compare July 8, 2021 07:48
Base automatically changed from surangap/icx-claimdfchtlc to main July 8, 2021 08:57
@codeclimate
Copy link

codeclimate bot commented Jul 9, 2021

Code Climate has analyzed commit c5f36ab and detected 0 issues on this pull request.

View more on Code Climate.

@netlify
Copy link

netlify bot commented Jul 9, 2021

✔️ Deploy Preview for jellyfish-defi ready!

🔨 Explore the source changes: c05b50f

🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/60e8168ffa642a0007a7bd5d

😎 Browse the preview: https://deploy-preview-407--jellyfish-defi.netlify.app

@github-actions
Copy link

github-actions bot commented Jul 9, 2021

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/jellyfish/dist/index.umd.js 21.31 KB (+0.07% 🔺) 427 ms (+0.07% 🔺) 173 ms (+0.38% 🔺) 599 ms

@codecov
Copy link

codecov bot commented Jul 9, 2021

Codecov Report

Merging #407 (0df354c) into main (3421144) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 0df354c differs from pull request most recent head c5f36ab. Consider uploading reports for the commit c5f36ab to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #407      +/-   ##
==========================================
+ Coverage   97.48%   97.50%   +0.01%     
==========================================
  Files          98      100       +2     
  Lines        2901     2923      +22     
  Branches      285      288       +3     
==========================================
+ Hits         2828     2850      +22     
  Misses         73       73              
Impacted Files Coverage Δ
...ages/jellyfish-transaction/src/script/dftx/dftx.ts 97.43% <ø> (ø)
...lyfish-transaction/src/script/dftx/dftx_account.ts 100.00% <ø> (ø)
...lyfish-transaction/src/script/dftx/dftx_balance.ts 100.00% <ø> (ø)
...ish-transaction/src/script/dftx/dftx_governance.ts 100.00% <ø> (ø)
...ish-transaction/src/script/dftx/dftx_masternode.ts 100.00% <ø> (ø)
...jellyfish-transaction/src/script/dftx/dftx_misc.ts 100.00% <ø> (ø)
...lyfish-transaction/src/script/dftx/dftx_oracles.ts 100.00% <ø> (ø)
...jellyfish-transaction/src/script/dftx/dftx_pool.ts 100.00% <ø> (ø)
...ellyfish-transaction/src/script/dftx/dftx_price.ts 100.00% <ø> (ø)
...ellyfish-transaction/src/script/dftx/dftx_token.ts 100.00% <ø> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b39bb0f...c5f36ab. Read the comment docs.

@fuxingloh
Copy link
Contributor

Btw there are flaky failing old tests, might be fixed when you can "close all offers", gonna to rerun them

https://github.com/DeFiCh/jellyfish/pull/407/checks?check_run_id=3042961198

@surangap surangap merged commit da1f467 into main Jul 12, 2021
@surangap surangap deleted the surangap/icx-listhtlcs branch July 12, 2021 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants