-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interface icx_listhtlcs
RPC
#407
Conversation
packages/jellyfish-api-core/__tests__/category/icxorderbook/listHTLCs.test.ts
Outdated
Show resolved
Hide resolved
packages/jellyfish-api-core/__tests__/category/icxorderbook/listHTLCs.test.ts
Outdated
Show resolved
Hide resolved
packages/jellyfish-api-core/__tests__/category/icxorderbook/listHTLCs.test.ts
Outdated
Show resolved
Hide resolved
packages/jellyfish-api-core/__tests__/category/icxorderbook/listHTLCs.test.ts
Outdated
Show resolved
Hide resolved
2917361
to
e4360f1
Compare
e55ea71
to
9d285a6
Compare
e4360f1
to
60b191d
Compare
f6dbc5a
to
51a05be
Compare
9d285a6
to
c05b50f
Compare
Code Climate has analyzed commit c5f36ab and detected 0 issues on this pull request. View more on Code Climate. |
✔️ Deploy Preview for jellyfish-defi ready! 🔨 Explore the source changes: c05b50f 🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/60e8168ffa642a0007a7bd5d 😎 Browse the preview: https://deploy-preview-407--jellyfish-defi.netlify.app |
packages/jellyfish-api-core/__tests__/category/icxorderbook/listHTLCs.test.ts
Outdated
Show resolved
Hide resolved
size-limit report 📦
|
packages/jellyfish-api-core/__tests__/category/icxorderbook/listHTLCs.test.ts
Outdated
Show resolved
Hide resolved
packages/jellyfish-api-core/__tests__/category/icxorderbook/listHTLCs.test.ts
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #407 +/- ##
==========================================
+ Coverage 97.48% 97.50% +0.01%
==========================================
Files 98 100 +2
Lines 2901 2923 +22
Branches 285 288 +3
==========================================
+ Hits 2828 2850 +22
Misses 73 73
Continue to review full report at Codecov.
|
packages/jellyfish-api-core/__tests__/category/icxorderbook/listHTLCs.test.ts
Show resolved
Hide resolved
Btw there are flaky failing old tests, might be fixed when you can "close all offers", gonna to rerun them https://github.com/DeFiCh/jellyfish/pull/407/checks?check_run_id=3042961198 |
What kind of PR is this?:
/kind feature
What this PR does / why we need it:
This PR will interface
icx_listhtlcs
RPC to jellyfishWhich issue(s) does this PR fixes?:
Fixes #
Additional comments?:
depends on #406