Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add removeOracle rpc #339

Merged
merged 9 commits into from
Jun 4, 2021
Merged

Add removeOracle rpc #339

merged 9 commits into from
Jun 4, 2021

Conversation

jingyi2811
Copy link
Contributor

@jingyi2811 jingyi2811 commented Jun 3, 2021

What kind of PR is this?:

/kind feature

What this PR does / why we need it:

Add removeOracle rpc

Which issue(s) does this PR fixes?:

Fixes part of #202

Additional comments?:

@codeclimate
Copy link

codeclimate bot commented Jun 3, 2021

Code Climate has analyzed commit 3c7ff99 and detected 0 issues on this pull request.

View more on Code Climate.

@jingyi2811 jingyi2811 mentioned this pull request Jun 3, 2021
30 tasks
@netlify
Copy link

netlify bot commented Jun 3, 2021

✔️ Deploy Preview for jellyfish-defi ready!

🔨 Explore the source changes: 9aa761d

🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/60b999f62506b7000b9af1e2

😎 Browse the preview: https://deploy-preview-339--jellyfish-defi.netlify.app

@github-actions
Copy link

github-actions bot commented Jun 3, 2021

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/jellyfish/dist/jellyfish.umd.js 19.92 KB (+0.1% 🔺) 399 ms (+0.1% 🔺) 168 ms (-0.11% 🔽) 567 ms

@codecov
Copy link

codecov bot commented Jun 3, 2021

Codecov Report

Merging #339 (6001a65) into main (9e6f5d5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 6001a65 differs from pull request most recent head 3c7ff99. Consider uploading reports for the commit 3c7ff99 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #339   +/-   ##
=======================================
  Coverage   97.07%   97.07%           
=======================================
  Files          93       93           
  Lines        2600     2602    +2     
  Branches      331      332    +1     
=======================================
+ Hits         2524     2526    +2     
  Misses         76       76           
Impacted Files Coverage Δ
packages/jellyfish-api-core/src/category/oracle.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e6f5d5...3c7ff99. Read the comment docs.

@jingyi2811 jingyi2811 changed the title Add removeoracle rpc Add removeOracle rpc Jun 4, 2021
@monstrobishi monstrobishi marked this pull request as ready for review June 4, 2021 06:20
@fuxingloh fuxingloh merged commit fbe4a22 into main Jun 4, 2021
@fuxingloh fuxingloh deleted the jimmy/removeoracle branch June 4, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants