-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jellyfish-api-core): implement refundHtlcAll #1324
Conversation
Code Climate has analyzed commit d7c9a05 and detected 0 issues on this pull request. View more on Code Climate. |
✅ Deploy Preview for jellyfishsdk ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
@@ Coverage Diff @@
## main #1324 +/- ##
==========================================
+ Coverage 88.21% 89.91% +1.70%
==========================================
Files 348 350 +2
Lines 10030 10115 +85
Branches 1224 1244 +20
==========================================
+ Hits 8848 9095 +247
+ Misses 1113 966 -147
+ Partials 69 54 -15
Continue to review full report at Codecov.
|
Docker build preview for jellyfish/apps is ready! Built with commit aaaa01d
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
(Regarding the return arr from ain.. if that does really matter.. we'd open issue on ain)
Hmm prefer to return array instead for consistencies. I am thinking if ain side is a bug, what if the wallet has multiple htlc, then it should return txid of each refunded. |
Does make sense that it'll want to return all the transactions made for the refund. But not sure when If so then I think I'll make it return a string array, but I'll just note it somewhere that there is this inconsistency then. |
packages/jellyfish-api-core/__tests__/category/spv/refundHtlcAll.test.ts
Outdated
Show resolved
Hide resolved
…ll.test.ts Co-authored-by: surangap <[email protected]>
d7c9a05
What this PR does / why we need it:
Implements spv
spv_refundhtlcall
rpc call.Which issue(s) does this PR fixes?:
Fixes part of #202
Additional comments?:
Need some confirmation with how the
ain
implementation of this rpc is. Right nowain
's implementation returns an array of strings, containing only one string, shown here.The rpc documentation from
ain
however shows that it returns a string txid, which is not the case.This current implementation for jellyfish deals with this by simply taking the first element of the returned array.
Edit: This rpc now returns a string array, faithful to its
ain
implementation.