Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SPV claimHtlc RPC #521

Merged
merged 1 commit into from
Aug 4, 2021
Merged

Added SPV claimHtlc RPC #521

merged 1 commit into from
Aug 4, 2021

Conversation

Jouzo
Copy link
Contributor

@Jouzo Jouzo commented Jul 29, 2021

What kind of PR is this?:

/kind feature

What this PR does / why we need it:

Adds SPV claimHtlc RPC

Which issue(s) does this PR fixes?:

Fixes part of #202

@codeclimate
Copy link

codeclimate bot commented Jul 29, 2021

Code Climate has analyzed commit 1ac3a09 and detected 0 issues on this pull request.

View more on Code Climate.

@netlify
Copy link

netlify bot commented Jul 29, 2021

✔️ Deploy Preview for jellyfish-defi ready!

🔨 Explore the source changes: 1ac3a09

🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/6109ac20efd49200071a9b60

😎 Browse the preview: https://deploy-preview-521--jellyfish-defi.netlify.app

@Jouzo Jouzo mentioned this pull request Jul 29, 2021
30 tasks
@github-actions
Copy link

github-actions bot commented Jul 29, 2021

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/jellyfish/dist/index.umd.js 22.35 KB (+0.1% 🔺) 447 ms (+0.1% 🔺) 175 ms (-6.28% 🔽) 622 ms

@codecov
Copy link

codecov bot commented Jul 29, 2021

Codecov Report

Merging #521 (1ac3a09) into main (3827626) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #521   +/-   ##
=======================================
  Coverage   97.42%   97.42%           
=======================================
  Files         112      112           
  Lines        3298     3300    +2     
  Branches      406      406           
=======================================
+ Hits         3213     3215    +2     
  Misses         85       85           
Impacted Files Coverage Δ
packages/jellyfish-api-core/src/category/spv.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3827626...1ac3a09. Read the comment docs.

@Jouzo Jouzo force-pushed the jouzo/spv_claimhtlc branch from eadf192 to 1ac3a09 Compare August 3, 2021 20:50
@Jouzo Jouzo marked this pull request as ready for review August 3, 2021 20:50
Copy link
Contributor

@surangap surangap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@fuxingloh fuxingloh merged commit 6402fc5 into main Aug 4, 2021
@fuxingloh fuxingloh deleted the jouzo/spv_claimhtlc branch August 4, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants