Add listLatestRawPrices rpc #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
� Conflicts: � packages/jellyfish-api-core/src/category/oracle.ts � website/docs/jellyfish/api/oracle.md
jingyi2811
requested review from
canonbrother,
fuxingloh,
monstrobishi,
surangap and
thedoublejay
as code owners
|
Code Climate has analyzed commit 0409334 and detected 0 issues on this pull request. View more on Code Climate. |
monstrobishi
suggested changes
Jun 8, 2021
packages/jellyfish-api-core/__tests__/category/oracle/listLatestRawPrices.test.ts
Outdated
Show resolved
Hide resolved
packages/jellyfish-api-core/__tests__/category/oracle/listLatestRawPrices.test.ts
Outdated
Show resolved
Hide resolved
size-limit report 📦
|
30 tasks
|
Still doing. Haven't finished |
Codecov Report
@@ Coverage Diff @@
## main #352 +/- ##
==========================================
- Coverage 97.16% 97.13% -0.03%
==========================================
Files 91 91
Lines 2642 2652 +10
Branches 339 341 +2
==========================================
+ Hits 2567 2576 +9
- Misses 75 76 +1
Continue to review full report at Codecov.
|
|
✔️ Deploy Preview for jellyfish-defi ready! 🔨 Explore the source changes: ff4aab0 🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/60c2f8512f4955000833b15c 😎 Browse the preview: https://deploy-preview-352--jellyfish-defi.netlify.app |
…ices # Conflicts: # packages/jellyfish-api-core/src/category/oracle.ts # website/docs/jellyfish/api/oracle.md
jingyi2811
commented
Jun 9, 2021
jingyi2811
commented
Jun 9, 2021
packages/jellyfish-api-core/__tests__/category/oracle/listLatestRawPrices.test.ts
Show resolved
Hide resolved
jingyi2811
commented
Jun 9, 2021
packages/jellyfish-api-core/__tests__/category/oracle/listLatestRawPrices.test.ts
Outdated
Show resolved
Hide resolved
monstrobishi
previously approved these changes
Jun 10, 2021
canonbrother
previously requested changes
Jun 11, 2021
packages/jellyfish-api-core/__tests__/category/oracle/listLatestRawPrices.test.ts
Show resolved
Hide resolved
thedoublejay
requested changes
Jun 11, 2021
thedoublejay
previously approved these changes
Jun 11, 2021
fuxingloh
approved these changes
Jun 11, 2021
packages/jellyfish-api-core/__tests__/category/oracle/listLatestRawPrices.test.ts
Show resolved
Hide resolved
packages/jellyfish-api-core/__tests__/category/oracle/listLatestRawPrices.test.ts
Show resolved
Hide resolved
packages/jellyfish-api-core/__tests__/category/oracle/listLatestRawPrices.test.ts
Show resolved
Hide resolved
packages/jellyfish-api-core/__tests__/category/oracle/listLatestRawPrices.test.ts
Show resolved
Hide resolved
packages/jellyfish-api-core/__tests__/category/oracle/listLatestRawPrices.test.ts
Show resolved
Hide resolved
surangap
approved these changes
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of PR is this?:
/kind feature
What this PR does / why we need it:
Add listLatestRawPrices rpc
Which issue(s) does this PR fixes?:
Fixes part of #202
Additional comments?: