Add spv_refundhtlcall #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bushstar
requested review from
bvbfan,
Mixa84,
monstrobishi,
ShengguangXiao,
surangap and
uzyn
as code owners
bvbfan
reviewed
Aug 18, 2021
Comment on lines
+888
to
+892
| // Sort by Bitcoin address | ||
| std::sort(htlcTransactions.begin(), htlcTransactions.end(), [](const std::pair<BRTransaction*, size_t>& lhs, const std::pair<BRTransaction*, size_t>& rhs){ | ||
| return strcmp(lhs.first->outputs[lhs.second].address, rhs.first->outputs[rhs.second].address) < 0; | ||
| }); | ||
|
|
There was a problem hiding this comment.
Why sorting? And why not in BRListHTLCReceived ?
There was a problem hiding this comment.
Will still need to be sorted in BRListHTLCReceived in the same way. I was thinking of adding later an option for the user to specify sort order, like TXID, time, address and so on. I could have used all three in testing but address order sufficed.
30 tasks
bvbfan
previously approved these changes
Aug 24, 2021
src/spv/spv_rpc.cpp
Outdated
| CWallet* const pwallet = GetWallet(request); | ||
|
|
||
| RPCHelpMan{"spv_refundhtlcall", | ||
| "\nGets all HTLC contracts stored in wallet and creates refunds transactions for a that have expired\n", |
There was a problem hiding this comment.
The help message reads not correct.
prasannavl
previously approved these changes
Oct 22, 2021
prasannavl
approved these changes
Oct 22, 2021
prasannavl
added a commit
that referenced
this pull request
Oct 30, 2021
* Add spv_refundhtlcall * sendmessage only populated on failure * sendmessage only populated on error * Set block heights in test to meet refund requirement * Fix lints * Update help test Co-authored-by: Prasanna Loganathar <[email protected]>
prasannavl
added a commit
that referenced
this pull request
Oct 30, 2021
* Add spv_refundhtlcall * sendmessage only populated on failure * sendmessage only populated on error * Set block heights in test to meet refund requirement * Fix lints * Update help test Co-authored-by: Prasanna Loganathar <[email protected]>
prasannavl
added a commit
that referenced
this pull request
Oct 30, 2021
* Add spv_refundhtlcall * sendmessage only populated on failure * sendmessage only populated on error * Set block heights in test to meet refund requirement * Fix lints * Update help test Co-authored-by: Prasanna Loganathar <[email protected]>
prasannavl
added a commit
that referenced
this pull request
Oct 30, 2021
* Add spv_refundhtlcall * sendmessage only populated on failure * sendmessage only populated on error * Set block heights in test to meet refund requirement * Fix lints * Update help test Co-authored-by: Prasanna Loganathar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a call to refund all HTLCs in the wallet for which the correct private key is known and has enough confirmations.
Fixes issue where only one HTLC output in a TX could be seen or spent.
Fixes issue where HTLC refund will try to spend output without the required confirmations.
Only shows sendmessage RPC response text when there's an error on send, otherwise this will always display that an unknown error has occured.