Added listHtlcOutputs RPC #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jouzo
requested review from
canonbrother,
fuxingloh,
monstrobishi and
surangap
as code owners
30 tasks
|
Code Climate has analyzed commit 9112783 and detected 0 issues on this pull request. View more on Code Climate. |
|
✔️ Deploy Preview for jellyfish-defi ready! 🔨 Explore the source changes: b0b2993 🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/611a0d34324056000834c46f 😎 Browse the preview: https://deploy-preview-581--jellyfish-defi.netlify.app |
size-limit report 📦
|
Codecov Report
@@ Coverage Diff @@
## main #581 +/- ##
==========================================
- Coverage 97.45% 97.45% -0.01%
==========================================
Files 117 118 +1
Lines 3463 3540 +77
Branches 425 435 +10
==========================================
+ Hits 3375 3450 +75
- Misses 88 90 +2
Continue to review full report at Codecov.
|
surangap
reviewed
Aug 16, 2021
surangap
reviewed
Aug 16, 2021
Jouzo
force-pushed
the
jouzo/spv_listhtlcoutputs
branch
from
9777209 to
cb47760
Compare
surangap
reviewed
Aug 16, 2021
packages/jellyfish-api-core/__tests__/category/spv/listHtlcsOutputs.test.ts
Outdated
Show resolved
Hide resolved
surangap
reviewed
Aug 16, 2021
packages/jellyfish-api-core/__tests__/category/spv/listHtlcsOutputs.test.ts
Show resolved
Hide resolved
surangap
suggested changes
Aug 16, 2021
…actor using Testing class from jellyfish-testing
fuxingloh
approved these changes
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of PR is this?:
/kind feature
What this PR does / why we need it:
Adds listHtlcOutputs RPC
Which issue(s) does this PR fixes?:
Fixes #202 (last issue in the series)