Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update @defichain/testcontainers to 1.7.0 #184

Merged
merged 8 commits into from
May 26, 2021
Merged

Update @defichain/testcontainers to 1.7.0 #184

merged 8 commits into from
May 26, 2021

Conversation

monstrobishi
Copy link
Contributor

What kind of PR is this?:

/kind chore

What this PR does / why we need it:

This is a regression test against 1.7.x branch of ain, a PR is created in order to run tests on CICD.

Additional comments?:

@monstrobishi monstrobishi requested a review from fuxingloh as a code owner May 4, 2021 07:49
@github-actions
Copy link

github-actions bot commented May 4, 2021 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/jellyfish/dist/jellyfish.umd.js 19.16 KB (0%) 384 ms (0%) 177 ms (+0.32% 🔺) 560 ms

@monstrobishi monstrobishi changed the title Update container to point at 1.7.x on dockerhub [WIP] Update container to point at 1.7.x on dockerhub May 4, 2021
@fuxingloh fuxingloh marked this pull request as draft May 4, 2021 08:04
@fuxingloh fuxingloh changed the title [WIP] Update container to point at 1.7.x on dockerhub Update testcontainers to 1.7.x May 4, 2021
@fuxingloh fuxingloh changed the title Update testcontainers to 1.7.x Update testcontainers to 1.7.x builds May 4, 2021
@fuxingloh fuxingloh mentioned this pull request May 6, 2021
Closed
@fuxingloh fuxingloh mentioned this pull request May 10, 2021
Closed
30 tasks
@codecov
Copy link

codecov bot commented May 16, 2021 •
edited
Loading

Codecov Report

Merging #184 (276c730) into main (159c913) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #184      +/-   ##
==========================================
+ Coverage   96.75%   96.84%   +0.08%     
==========================================
  Files          88       88              
  Lines        2342     2342              
  Branches      299      299              
==========================================
+ Hits         2266     2268       +2     
+ Misses         76       74       -2
Impacted Files Coverage Δ
...tcontainers/src/chains/reg_test_container/index.ts 100.00% <ø> (ø)
...kages/testcontainers/src/chains/defid_container.ts 93.75% <100.00%> (ø)
...ainers/src/chains/reg_test_container/masternode.ts 98.14% <0.00%> (+3.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 159c913...276c730. Read the comment docs.

@codeclimate
Copy link

codeclimate bot commented May 24, 2021 •
edited
Loading

Code Climate has analyzed commit 276c730 and detected 0 issues on this pull request.

View more on Code Climate.

@netlify
Copy link

netlify bot commented May 24, 2021 •
edited
Loading

Deploy Preview for jellyfish-defi ready!

Built with commit e47b258

https://deploy-preview-184--jellyfish-defi.netlify.app

@fuxingloh fuxingloh added the kind/dependencies Pull requests that update a dependency file label May 25, 2021
@defichain-bot defichain-bot removed the kind/chore Non feature change label May 25, 2021
@fuxingloh fuxingloh changed the title Update testcontainers to 1.7.x builds Update @defichain/testcontainers to 1.7.0 May 25, 2021
@fuxingloh fuxingloh marked this pull request as ready for review May 25, 2021 12:20
@fuxingloh fuxingloh merged commit 5c63ca0 into main May 26, 2021
@fuxingloh fuxingloh deleted the chore/test_1.7.x branch May 26, 2021 09:22
@fuxingloh fuxingloh mentioned this pull request Jul 12, 2021
Closed
6 tasks
@fuxingloh fuxingloh mentioned this pull request Jul 23, 2021
Closed
38 tasks
eli-lim pushed a commit that referenced this pull request Mar 27, 2022
@fuxingloh
added model probes indicator for actuator for healthcheck (#184)
6ad1643
canonbrother pushed a commit that referenced this pull request Jun 1, 2022
@fuxingloh
added model probes indicator for actuator for healthcheck (#184)
e879ea3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingyi2811 jingyi2811 jingyi2811 approved these changes

@fuxingloh fuxingloh fuxingloh approved these changes

@canonbrother canonbrother Awaiting requested review from canonbrother canonbrother is a code owner

@ivan-zynesis ivan-zynesis Awaiting requested review from ivan-zynesis ivan-zynesis is a code owner

@thedoublejay thedoublejay Awaiting requested review from thedoublejay

Assignees
No one assigned
Labels
kind/dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@monstrobishi @fuxingloh @jingyi2811 @surangap @defichain-bot