-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added SPV decodeHtlcScript RPC #513
Conversation
✔️ Deploy Preview for jellyfish-defi ready! 🔨 Explore the source changes: c4e5e0a 🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/61080b1ccbf8bd00079dace1 😎 Browse the preview: https://deploy-preview-513--jellyfish-defi.netlify.app |
Code Climate has analyzed commit 50d88a8 and detected 0 issues on this pull request. View more on Code Climate. |
3dc334a
to
c4e5e0a
Compare
size-limit report 📦
|
Codecov Report
@@ Coverage Diff @@
## main #513 +/- ##
==========================================
+ Coverage 97.36% 97.42% +0.05%
==========================================
Files 112 112
Lines 3305 3301 -4
Branches 409 407 -2
==========================================
- Hits 3218 3216 -2
+ Misses 87 85 -2
Continue to review full report at Codecov.
|
packages/jellyfish-api-core/__tests__/category/spv/decodeHtlcScript.test.ts
Outdated
Show resolved
Hide resolved
packages/jellyfish-api-core/__tests__/category/spv/decodeHtlcScript.test.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good to me.
yea looks great too |
I am not sure to understand correctly what you mean |
ohh.. just the management stuff, the jellyfish pr will auto merge while getting 2 approvals |
Got it ;) |
Oh yeah, it's gives me a better understanding of |
What kind of PR is this?:
/kind feature
What this PR does / why we need it:
Adds SPV decodeHtlcScript RPC
Which issue(s) does this PR fixes?:
Fixes part of #202