Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SPV decodeHtlcScript RPC #513

Merged
merged 3 commits into from
Aug 3, 2021
Merged

Conversation

Jouzo
Copy link
Contributor

@Jouzo Jouzo commented Jul 28, 2021

What kind of PR is this?:

/kind feature

What this PR does / why we need it:

Adds SPV decodeHtlcScript RPC

Which issue(s) does this PR fixes?:

Fixes part of #202

@netlify
Copy link

netlify bot commented Jul 28, 2021

✔️ Deploy Preview for jellyfish-defi ready!

🔨 Explore the source changes: c4e5e0a

🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/61080b1ccbf8bd00079dace1

😎 Browse the preview: https://deploy-preview-513--jellyfish-defi.netlify.app

@codeclimate
Copy link

codeclimate bot commented Jul 28, 2021

Code Climate has analyzed commit 50d88a8 and detected 0 issues on this pull request.

View more on Code Climate.

@Jouzo Jouzo force-pushed the jouzo/spv_decodehtlcscript branch from 3dc334a to c4e5e0a Compare August 2, 2021 15:11
@Jouzo Jouzo marked this pull request as ready for review August 2, 2021 15:11
@github-actions
Copy link

github-actions bot commented Aug 2, 2021

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/jellyfish/dist/index.umd.js 22.33 KB (+0.11% 🔺) 447 ms (+0.11% 🔺) 178 ms (-1.41% 🔽) 624 ms

@codecov
Copy link

codecov bot commented Aug 2, 2021

Codecov Report

Merging #513 (50d88a8) into main (d283bd5) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #513      +/-   ##
==========================================
+ Coverage   97.36%   97.42%   +0.05%     
==========================================
  Files         112      112              
  Lines        3305     3301       -4     
  Branches      409      407       -2     
==========================================
- Hits         3218     3216       -2     
+ Misses         87       85       -2     
Impacted Files Coverage Δ
packages/jellyfish-api-core/src/category/spv.ts 100.00% <100.00%> (ø)
packages/jellyfish-api-core/src/category/token.ts 100.00% <0.00%> (ø)
...ackages/jellyfish-api-core/src/category/account.ts 100.00% <0.00%> (ø)
...ges/jellyfish-transaction/src/script/dftx/index.ts 100.00% <0.00%> (ø)
...kages/testcontainers/src/chains/defid_container.ts 92.22% <0.00%> (+0.38%) ⬆️
...ages/testcontainers/src/chains/docker_container.ts 97.67% <0.00%> (+2.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d283bd5...50d88a8. Read the comment docs.

Copy link
Contributor

@surangap surangap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to me.

@canonbrother
Copy link
Contributor

yea looks great too
FYI, the last approval of kind/feature PR is required @fuxingloh 's approval

@Jouzo
Copy link
Contributor Author

Jouzo commented Aug 3, 2021

yea looks great too
FYI, the last approval of kind/feature PR is required @fuxingloh 's approval

I am not sure to understand correctly what you mean

@canonbrother
Copy link
Contributor

yea looks great too
FYI, the last approval of kind/feature PR is required @fuxingloh 's approval

I am not sure to understand correctly what you mean

ohh.. just the management stuff, the jellyfish pr will auto merge while getting 2 approvals
surangap took 1
then the last must be fuxing

@Jouzo
Copy link
Contributor Author

Jouzo commented Aug 3, 2021

yea looks great too
FYI, the last approval of kind/feature PR is required @fuxingloh 's approval

I am not sure to understand correctly what you mean

ohh.. just the management stuff, the jellyfish pr will auto merge while getting 2 approvals
surangap took 1
then the last must be fuxing

Got it ;)

@fuxingloh
Copy link
Contributor

yea looks great too
FYI, the last approval of kind/feature PR is required @fuxingloh 's approval

I am not sure to understand correctly what you mean

ohh.. just the management stuff, the jellyfish pr will auto merge while getting 2 approvals
surangap took 1
then the last must be fuxing

Got it ;)

Oh yeah, it's gives me a better understanding of kind/features going into jellyfish to understanding the evolving nature of the project.

@fuxingloh fuxingloh merged commit 3827626 into main Aug 3, 2021
@fuxingloh fuxingloh deleted the jouzo/spv_decodehtlcscript branch August 3, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants