Master tracking issue for prototype branch cut 3

[BenHenning]

This issue is tracking all of the work we want to include in our third prototype branch cut, including work items that should not be submitted onto develop. All work items here are based on the corresponding workstream for this branch cut.

Current PRs that are being targeted:

• Audio fixes (Fixes #307: Finish cellular functionality for audio streaming #358)
• Profile system (Partially fixes #16: Implemented profile management controller #269, Fixes part of #16 and #44: Implementation of ProfileChooserFragment #326, Fixes part of #16: Implementation of AdminAuthActivity and AddProfileActivity #327, Fixes part of #16: Implementation of PinPasswordActivity #328)
• Audio Bug Fix - Remove elevation #493 (elevation fix)
• Fix #433: Add content and change the thumbnail image for the ratios concept card #492 (add content & change thumbnail image for ratios concept card)
• Fix #370: Remove all temporary topic, skill, exploration, story, and question data #350 (remove temp data)
• Fix #111: Introduce question progress controller implementation #397 (training controller impl)
• Fix #387: Add support for showing concept cards in explorations [BLOCKED ON MISSING TESTS] #422 (show concept cards in explorations)
• Fix #159: Introduce question player UI structure #500 (question training fragment)
• Update leave topic dialog text #498: Update leave dialog text
• Fix #417: Ensure state navigation buttons are de-duplicated, the same size, and aligned #495: Align continue buttons
• Maybe: audio highlighting (Audio Content highlight [DO NOT MERGE] #491)
• Maybe: error detection for fractions (Fix part #376: Fraction input interaction view validation #419)
• Maybe: updated RecyclerView for home fragment (Fix #389: Low-fi Home fragment implementation 2 (Nested RecyclerView) #477)
• Maybe: Fix #377: Control submit button #418 (submit button color -- needs updating)
• Maybe: Fix part of #140: Topic play animation #486 (topic play animation)
• Maybe: Fix #456: Improvised bullet code #490 (bullet list improvements)

Issues that are expected to be fully resolved from the above list of PRs:

• Implement multi-user profile management system [Blocked: #14, #167] #16
• Derive a ratio concept card picture & content is wrong #433
• Profile page is cut off with small display size #431
• Support showing concept cards in the exploration player #387
• Submit and continue buttons need proper disabled colors #377
• Remove non-JSON test data #370
• Finish cellular functionality for audio streaming #307
• UI Structure: QuestionTrainingFragment [Blocked: #120, #158] #159
• Implement QuestionAssessmentProgressController [Blocked: #112] #111
• Gravitars/avatar rendering [Blocked: #44] #47
• Full UI: ProfileSelectionFragment/Activity [Blocked: #11, #16, #168] #44
• Full UI: StateCardFragment [Blocked: #17, #26, #28, #113, #115, #163] #164 (maybe)
• Final UI: Topic play tab fragment [Blocked: #15, #137] #140 (maybe)
• Final UI: Topic activity/fragment [Blocked: #15] #23 (maybe)

Issues that require additional work after the above:

• Core state experience is janky #434 (core experience is janky -> requires more animation work in state fragment)
• Numerator/denominator concept card should have images at the bottom #428 (num/denom concept card missing images -> requires updating the JSON with images)
• Text-based interactions need real-time answer validation #376 (interaction validation -> after fractions, numeric input needs validation support)
• Finalize UIs for smaller screens [Blocked: #5250] #360 (finalize UIs for smaller screens -> after profiles is done, need to topic play tabs & list)
• Sometimes fraction input doesn't let you submit #425 (fraction answer submission sometimes breaks)
• Right alignment of submitted answers looks wrong #499 (right alignment of user feedback looks incorrect)

Issues that may require additional work but whose additional work is unclear:

• Full UI: ExplorationPlayerFragment/Activity #42 (exp fragment/activity full UI -> not sure what work remains)
• Full UI: Question training interface [Blocked: #110, #27, #159] #40 (questions final UI -> likely out of scope)
• Full UI: EndExplorationInteractionView [Blocked: #15, #157] #35 (end exploration full UI -> not sure what work remains)
• Full UI: ContinueInteractionView [Blocked: #15, #156] #34 (continue button interaction full UI -> need to display continue button name from customization args/not in scope)
• Final UI: ConceptCardFragment [Blocked: #15, #160] #24 (concept card final UI -> not sure what work remains)

Other work that needs to be done on temp branch that shouldn't be checked in:

• Hardcode profiles
• Enable caching

[BenHenning]

/cc @oppia/oppia-android

[BenHenning]

FYI: The work items tracked here are the priority items. We should aim to submit fixes for all of these by EOD PST Monday 2 December / EOD IST Tuesday 3 December.

[BenHenning]

NB: The 'maybe' targets will be resolved based on how much progress we make on these items by the target Monday/Tuesday submission dates.

[rt4914]

@BenHenning #418 is not solving the Submit button issue. It was created correctly but the approach was incorrect and the approach suggested by you, I was not able to correctly work on that to solve the issue, so it is kind of stuck.

[BenHenning]

Ack thanks @rt4914. We might avoid trying to get that in today due to other higher priority fixes being needed.

[BenHenning]

Issues that we observed while testing & developing:

• Images are occasionally cut off in exploration & question players (expected fix: Rich text image centre fix #507)
• Fractions fails validation for mixed numbers (e.g. '3 1/2' for second state of Meaning of Equal Parts) (expected fix: changes in Fix part #376: Fraction input interaction view validation #419 + Fix #425: Update HasNumeratorEqualTo classifier to match the parsing logic #510)
• Fractions fails submission for some numbers (e.g. '1/2' for second state of Meaning of Equal Parts) (expected fix: Fix #425: Update HasNumeratorEqualTo classifier to match the parsing logic #510)
• Audio is not correctly autoplaying when enabled and moving to a new state (expected fix: Fix part of #494: Audio autoplay issue fix #515)
• Audio content card highlighting isn't working (expected fix: Fix part of #494: Audio Content highlighting  #514)
• Images are not properly being cached in all cases, and not at all for questions
• We need to turn off the internet restriction for audio streaming on the temp branch for the meaning of equal parts since we are caching audio locally for that lesson (expected fix already on temp-integration-pt3)
• Image relayouting causing jankiness in both exploration and question player (works fine on 5X, now janky on ZTE)
• Previous answers not properly recollapsing in the question player (Past expanded answers do not collapse in the question player #511) (fixed directly on branch)
• Questions player currently renders questions like an exploration rather than like the mocks (not feasible to fix for temp branch)
• Questions player does not track right-on-first-try nor report that at the end of the session (not feasible to fix for temp branch)
• LaTeX expressions are not rendering correctly (In Some explorations expressions are missing. #513) (not feasible to fix for temp branch)
• Item selection allows submission when no items are selected (Itemselection Interaction allows to submit answer when no any selection is done. #512) (not fixing in temp branch: not a bad bug, and unlikely to be found)

---

Other bugs found after additional testing:

• Bullet points look weird on mdpi devices
• We're missing a concept card link when entering 4/5 on the third state of Meaning of Equal Parts
• Ratios concept card is janky on mdpi devices because it gets cut-off
• Image loading is janky on slower devices (this is being tracked above since it wasn't fully solved)
• LaTeX text is noticeable (unlike above, the goal here is to replace the text with non-LaTeX rather than introduce LaTeX support)
• Line breaking happens sometimes in unexpected places, especially on mdpi devices
• It's unexpected that the end of the questions training session can scroll on mdpi devices

[BenHenning]

Note that progress in this issue corresponds to fixes on temp-integration-pt3, not develop. We will start cutting lower priority breakages. This branch can be viewed in #506.

[BenHenning]

Priority items:

• LaTeX removal
• Concept card link
• Ratios concept card spacing
• Line break improvements
• Fix offline trigger (it's set for the wrong exploration)

Stretch:

• Bullet list fixes

[BenHenning]

NB: content highlighting now seems to be working correctly.

[rt4914]

@BenHenning Bullets have been improvised to support MDPI as well XHDPI and other devices.
Code updated in #490

[BenHenning]

Thanks @rt4914! I'll merge that in the temp branch again and verify it on the device we originally noticed it on.

[BenHenning]

@rt4914 they look a bit better, but I think we still need to move the bullet list a bit lower since it seems to be aligned on the top of the line, and that causes a larger visual discrepancy on a mdpi device.

[rt4914]

@BenHenning Okay, I will check and update once again.

[rt4914]

@rt4914 they look a bit better, but I think we still need to move the bullet list a bit lower since it seems to be aligned on the top of the line, and that causes a larger visual discrepancy on a mdpi device.

Just updated #490 . Check this comment: #490 (comment)

[BenHenning]

All work here has either been completed or is now being tracked as part of a milestone.