Fix #456: Improvised bullet code

[rt4914]

Explanation

This PR tries to improvise on bullets in HtmlParser

Checklist

• The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
• The PR follows the style guide.
• The PR does not contain any unnecessary auto-generated code from Android Studio.
• The PR is made from a branch that's not called "develop".
• The PR is made from a branch that is up-to-date with "develop".
• The PR's branch is based on "develop" and not on any other branch.
• The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

[veena14cs]

Code looks good to me. I have one concern in this screenshot why always 2nd option is improper.

[veena14cs]

LGTM nice work.

[nikitamarysolomanpvt]

Implementation LGTM (@mschanteltc suggestion... bullet design can be improvised )

[mschanteltc]

For the content in the blue box, can we indent just the text that is bullet pointed by 32 px? It would look similar to how the Content Card is formatted.

For the submitted answer, let's have the text be aligned to the left. The size of the box will depend on which answer's text is the longest. It should look like this answer on the Question Player. Remember that answers in the Exploration Player will format user's responses differently by having the box on the right side.

[BenHenning]

@mschanteltc one thing that confuses me about how we format this for the question player: learners also receive feedback for answers in the question player. Shouldn't we have the same left/right alignment to indicate the back-and-forth conversation flow?

@seanlip as well in case I'm missing something with questions.

[seanlip]

I think the idea is that explorations are meant to be a "conversation", whereas questions don't really have that sense -- so the UI is a little different. But if it's hard to do that, it doesn't matter so much I think.

[BenHenning]

I understand the product side, but I don't understand how the UI can represent that per the current mocks. Questions have feedback for answers, so it needs to be conversational. The current mocks assume that there isn't feedback for answers to questions, but the current questions structures do have feedback.

[mschanteltc]

If a user does get a problem incorrect in the Question Player, the feedback should be short like in this mock. For the Exploration Player, feedback should be more explanatory while the Question Player provides smaller hints or prompts them to "try again."

[BenHenning]

Thanks @mschanteltc.

@rt4914 deferring this review until the changes Chantel requested are done.

[rt4914]

For the content in the blue box, can we indent just the text that is bullet pointed by 32 px? It would look similar to how the Content Card is formatted.

For the submitted answer, let's have the text be aligned to the left. The size of the box will depend on which answer's text is the longest. It should look like this answer on the Question Player. Remember that answers in the Exploration Player will format user's responses differently by having the box on the right side.

@mschanteltc Please check these screenshots
I have increased the starting indent space and bullet radius.

[rt4914]

@BenHenning As mentioned in #494 the bullets were not correct in MDPI device. So I have updated the code. The only concern is that the dimens are in utility module and also, I had to inject activity to get the context to get resources.

[rt4914]

@BenHenning I have added y-offset to bullets to make it look more aligned with text.

MDPI screenshot

XHDPI screenshot