Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add screenshot testing test cases for CustomBulletSpan [BLOCKED on ScreenshotTesting] #562

Open
rt4914 opened this issue Dec 18, 2019 · 1 comment
Open

Add screenshot testing test cases for CustomBulletSpan [BLOCKED on ScreenshotTesting] #562

rt4914 opened this issue Dec 18, 2019 · 1 comment
Labels
enhancement End user-perceivable enhancements. Impact: Low Low perceived user impact (e.g. edge cases). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@rt4914
Copy link
Contributor

rt4914 commented Dec 18, 2019

CustomBulletSpan is responsible for drawing bullets in rich-text (HtmlParser). We should add tests to verify whether this drawing logic work correctly or not across all devices. These will be Screenshot Tests
Comment Reference: #490 (comment)
Sample Reference: https://facebook.github.io/screenshot-tests-for-android/

Screenshot_1576654589
@rt4914 rt4914 mentioned this issue Dec 18, 2019
Merged
8 tasks
@rt4914 rt4914 changed the title Add screenshot testing test cases for CustomBulletSpan Add screenshot testing test cases for CustomBulletSpan [BLOCKED on ScreenshotTesting] Apr 24, 2020
@BenHenning BenHenning added this to the Backlog milestone Jun 23, 2020
@Broppia Broppia added Impact: Low Low perceived user impact (e.g. edge cases). user_team labels Jul 29, 2022
@BenHenning BenHenning added Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Z-ibt Temporary label for Ben to keep track of issues he's triaged. issue_user_developer labels Sep 15, 2022
@BenHenning
Copy link
Member

NB: Considering this part of developer workflow since it could be a nice case study for screenshot testing once that infrastructure is introduced.

@BenHenning BenHenning removed this from the Backlog milestone Sep 16, 2022
@seanlip seanlip added enhancement End user-perceivable enhancements. and removed issue_type_infrastructure labels Mar 28, 2023
@MohitGupta121 MohitGupta121 added the Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. label Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement End user-perceivable enhancements. Impact: Low Low perceived user impact (e.g. edge cases). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Developer Workflow & Infrastructure - Android
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
5 participants
@rt4914 @seanlip @BenHenning @MohitGupta121 @Broppia