Implement multi-user profile management system [Blocked: #14, #167] #16
Assignees
Labels
Priority: Important
This work item is really important to complete for its milestone, but it can be scoped out.
Z-ibt
Temporary label for Ben to keep track of issues he's triaged.
Milestone
Comments
BenHenning
added
Type: Improvement
Priority: Essential
|
This is blocked on #14. |
This was referenced Aug 2, 2019
BenHenning
changed the title
BenHenning
added
Priority: Important
BenHenning
changed the title
BenHenning
changed the title
BenHenning
changed the title
|
This is also blocked on #167. |
BenHenning
modified the milestones:
Prototype -- UI (high fidelity),
Prototype -- Infra
|
This shouldn't have been closed @jamesxu0 since you still have pending PRs. |
BenHenning
added
Workstream: Finalize Prototype pt1 (15-20 Nov)
and removed
Status: In design
labels
29 tasks
jamesxu0
added a commit
that referenced
this issue
Dec 5, 2019
…326) * implemented get and delete * Finished test cases * added observing cachestore * Fixed test cases * Finished first draft of implementation * Added additional checks to setCurrentProfileId * Added more test cases * Finished test stubs * Finished test cases * Added query string to gravatar * primed cache on init * Fixed typo * Fixed addProfile test case * added create method to PersistentCacheStore * added setTimestamp and setAdmin * changed isAdmin to default to false * Added update last logged in * Started working on chooser * debugging * Added UI for chooser * added click functionality * Minor fixes * Updated to use deferred value from persistentCacheStore * Updated to use login * Ensured result is error to post error value * name can only be letters and unique check now case insensitive * Added profile sorting by last accessed * Fixed margins and added gradient * allow names to have spaces * Added image rotation and compression * fixed api requires for exifinterface * Changed gradle dependency * Added new asset and changed colors * Sorted alphabetically * added local default to tolowercase * started profile test helper * Removed broken test, couldn't get mockito to work * Added ProfileTestHelperTest * added test case for profilechooserfragment * using string.xml values in tests * Minor fixes and added default profile avatar * minor fixes * added endline * Minor fixes. * Started updating to DataProviders * Fixed loginToProfile * Minor fixes * Added comments and new test. * minor fixes * Fixed bug * Added vector version of avatar * Minor fixes. * Converted livedata to dataproviders * Minor fixes * Removed coroutines from test. * Removed ExperimentalCoroutinesApi * Removed import * Removed ExperimentalCouroutinesApi * Fixed failing test cases * Updated xml to multiples of 4 * Added annotations. * Fixed test * Fixed splash activity test * Fixed ProfileTestHelper
jamesxu0
added a commit
that referenced
this issue
Dec 5, 2019
…Activity (#327) * implemented get and delete * Finished test cases * added observing cachestore * Fixed test cases * Finished first draft of implementation * Added additional checks to setCurrentProfileId * Added more test cases * Finished test stubs * Finished test cases * Added query string to gravatar * primed cache on init * Fixed typo * Fixed addProfile test case * added create method to PersistentCacheStore * added setTimestamp and setAdmin * changed isAdmin to default to false * Added update last logged in * Started working on chooser * debugging * Added UI for chooser * added click functionality * Minor fixes * Started basic admin auth and add profile * Updated to use deferred value from persistentCacheStore * Updated to use login * Ensured result is error to post error value * name can only be letters and unique check now case insensitive * Added profile sorting by last accessed * Fixed margins and added gradient * allow names to have spaces * Switched fragments to activities * Finished admin auth styling * Styled inputs for add profile * Fixed name only letters toast * Added support for upload image * Started custom view * added upload image and fixed input styling * Added image rotation and compression * Added red color * fixed api requires for exifinterface * Changed gradle dependency * Added error handling ui support * Added new asset and changed colors * hide keyboard on create * changed selectedImage to private * Moved bindingadapter to companion object * removed fragment checks * Sorted alphabetically * added local default to tolowercase * updated comment * Updated key * added info icon * started profile test helper * Removed broken test, couldn't get mockito to work * Added ProfileTestHelperTest * added test case for profilechooserfragment * Added test for AdminAuthActivity * using string.xml values in tests * Started AddProfileActivityTest * Finished test cases * Minor fixes and added default profile avatar * minor fixes * added endline * Minor fixes * removed resources * Minor fixes. * Started updating to DataProviders * Fixed loginToProfile * Minor fixes * Added comments and new test. * minor fixes * Fixed bug * Added vector version of avatar * Minor fixes. * Converted livedata to dataproviders * Minor fixes * Removed coroutines from test. * Added helper methods * Removed ExperimentalCoroutinesApi * Removed import * Removed ExperimentalCouroutinesApi * Addressed comments * Fixed failing test cases * Updated xml to multiples of 4 * Fixed dp values
jamesxu0
added a commit
that referenced
this issue
Dec 13, 2019
* implemented get and delete * Finished test cases * added observing cachestore * Fixed test cases * Finished first draft of implementation * Added additional checks to setCurrentProfileId * Added more test cases * Finished test stubs * Finished test cases * Added query string to gravatar * primed cache on init * Fixed typo * Fixed addProfile test case * added create method to PersistentCacheStore * added setTimestamp and setAdmin * changed isAdmin to default to false * Added update last logged in * Started working on chooser * debugging * Added UI for chooser * added click functionality * Minor fixes * Started basic admin auth and add profile * Updated to use deferred value from persistentCacheStore * Updated to use login * Ensured result is error to post error value * name can only be letters and unique check now case insensitive * Added profile sorting by last accessed * Fixed margins and added gradient * allow names to have spaces * Switched fragments to activities * Finished admin auth styling * Styled inputs for add profile * Fixed name only letters toast * Added support for upload image * Started custom view * added upload image and fixed input styling * Added image rotation and compression * Added red color * fixed api requires for exifinterface * Changed gradle dependency * Added error handling ui support * Added new asset and changed colors * hide keyboard on create * changed selectedImage to private * Moved bindingadapter to companion object * Started activity * removed fragment checks * Finished basic flow of pin password * Added show password button * Added input to dialog * Sorted alphabetically * added local default to tolowercase * updated comment * Renamed keys * Updated key * Changed to getProfile from database * Added change pin dialogs * Added pin input animation and go to play store * added info icon * started profile test helper * Removed broken test, couldn't get mockito to work * Added ProfileTestHelperTest * added test case for profilechooserfragment * Added test for AdminAuthActivity * using string.xml values in tests * Started AddProfileActivityTest * Finished test cases * Finished test cases and adjusted sizes * Minor fixes and added default profile avatar * minor fixes * added endline * Minor fixes * removed resources * Minor fixes * Minor fixes. * Started updating to DataProviders * Fixed recyclerview * Fixed loginToProfile * Minor fixes * Added comments and new test. * minor fixes * Fixed bug * Added vector version of avatar * Minor fixes. * Converted livedata to dataproviders * Minor fixes * Removed coroutines from test. * Added helper methods * Removed ExperimentalCoroutinesApi * Removed import * Removed ExperimentalCouroutinesApi * Addressed comments * Fixed Project.xml * Addressed all comments. * Fixed failing test cases * Updated xml to multiples of 4 * Fixed dp values * Minor fixes * Fixed dp * Fixed ProfileTestHelper * Added Ben's createTimer * Addressed comments in previous PRs that didn't get pushed before. * Removed lines * Minor fixes. * Removed space.
jamesxu0
added a commit
that referenced
this issue
Dec 14, 2019
…22, #48] (#542) * implemented get and delete * Finished test cases * added observing cachestore * Fixed test cases * Finished first draft of implementation * Added additional checks to setCurrentProfileId * Added more test cases * Finished test stubs * Finished test cases * Added query string to gravatar * primed cache on init * Fixed typo * Fixed addProfile test case * added create method to PersistentCacheStore * added setTimestamp and setAdmin * changed isAdmin to default to false * Added update last logged in * Started working on chooser * debugging * Added UI for chooser * added click functionality * Minor fixes * Started basic admin auth and add profile * Updated to use deferred value from persistentCacheStore * Updated to use login * Ensured result is error to post error value * name can only be letters and unique check now case insensitive * Added profile sorting by last accessed * Fixed margins and added gradient * allow names to have spaces * Switched fragments to activities * Finished admin auth styling * Styled inputs for add profile * Fixed name only letters toast * Added support for upload image * Started custom view * added upload image and fixed input styling * Added image rotation and compression * Added red color * fixed api requires for exifinterface * Changed gradle dependency * Added error handling ui support * Added new asset and changed colors * hide keyboard on create * changed selectedImage to private * Moved bindingadapter to companion object * Started activity * removed fragment checks * Finished basic flow of pin password * Added show password button * Added input to dialog * Sorted alphabetically * added local default to tolowercase * updated comment * Renamed keys * Updated key * Changed to getProfile from database * Added change pin dialogs * Added pin input animation and go to play store * added info icon * started profile test helper * Removed broken test, couldn't get mockito to work * Added ProfileTestHelperTest * added test case for profilechooserfragment * Added test for AdminAuthActivity * using string.xml values in tests * Started AddProfileActivityTest * Finished test cases * Finished test cases and adjusted sizes * Minor fixes and added default profile avatar * minor fixes * added endline * Minor fixes * removed resources * Minor fixes * Minor fixes. * Started updating to DataProviders * Fixed recyclerview * Fixed loginToProfile * Minor fixes * Added comments and new test. * minor fixes * Fixed bug * Added vector version of avatar * Minor fixes. * Converted livedata to dataproviders * Minor fixes * Removed coroutines from test. * Added helper methods * Removed ExperimentalCoroutinesApi * Removed import * Removed ExperimentalCouroutinesApi * Addressed comments * Fixed Project.xml * Addressed all comments. * Fixed failing test cases * Updated xml to multiples of 4 * Fixed dp values * Minor fixes * Fixed dp * Fixed ProfileTestHelper * Added avatar color support. * Added Ben's createTimer * Addressed comments in previous PRs that didn't get pushed before. * Removed lines * Added admin pin creation flow * Fixed tests * Merge branch 'profile-avatar-colors' into profile-admin-flow * Added back button dialog to home activity * Initial changes, fragments to activities * Added basic recyclerview * Added recyclerview databinding * added new line * Updated log statement * Updated domain test case * Added AdminPinTests * Removed unused imports * Finished test cases * Cleaner profile avatar design * Updated profile:src * Removed textUtils * Reverted splash activity * Removed unused imports * Updated to now store colorHex and other fixes. * Updated comment. * Updated to colorRgb * Added fixes * Updated to force admin. * Updated comments. * Nit fixes.
jamesxu0
added a commit
that referenced
this issue
Dec 14, 2019
…ty, and ProfileResetPinActivity in settings [Blocked #22, #48] (#543) * implemented get and delete * Finished test cases * added observing cachestore * Fixed test cases * Finished first draft of implementation * Added additional checks to setCurrentProfileId * Added more test cases * Finished test stubs * Finished test cases * Added query string to gravatar * primed cache on init * Fixed typo * Fixed addProfile test case * added create method to PersistentCacheStore * added setTimestamp and setAdmin * changed isAdmin to default to false * Added update last logged in * Started working on chooser * debugging * Added UI for chooser * added click functionality * Minor fixes * Started basic admin auth and add profile * Updated to use deferred value from persistentCacheStore * Updated to use login * Ensured result is error to post error value * name can only be letters and unique check now case insensitive * Added profile sorting by last accessed * Fixed margins and added gradient * allow names to have spaces * Switched fragments to activities * Finished admin auth styling * Styled inputs for add profile * Fixed name only letters toast * Added support for upload image * Started custom view * added upload image and fixed input styling * Added image rotation and compression * Added red color * fixed api requires for exifinterface * Changed gradle dependency * Added error handling ui support * Added new asset and changed colors * hide keyboard on create * changed selectedImage to private * Moved bindingadapter to companion object * Started activity * removed fragment checks * Finished basic flow of pin password * Added show password button * Added input to dialog * Sorted alphabetically * added local default to tolowercase * updated comment * Renamed keys * Updated key * Changed to getProfile from database * Added change pin dialogs * Added pin input animation and go to play store * added info icon * started profile test helper * Removed broken test, couldn't get mockito to work * Added ProfileTestHelperTest * added test case for profilechooserfragment * Added test for AdminAuthActivity * using string.xml values in tests * Started AddProfileActivityTest * Finished test cases * Finished test cases and adjusted sizes * Minor fixes and added default profile avatar * minor fixes * added endline * Minor fixes * removed resources * Minor fixes * Minor fixes. * Started updating to DataProviders * Fixed recyclerview * Fixed loginToProfile * Minor fixes * Added comments and new test. * minor fixes * Fixed bug * Added vector version of avatar * Minor fixes. * Converted livedata to dataproviders * Minor fixes * Removed coroutines from test. * Added helper methods * Removed ExperimentalCoroutinesApi * Removed import * Removed ExperimentalCouroutinesApi * Addressed comments * Fixed Project.xml * Addressed all comments. * Fixed failing test cases * Updated xml to multiples of 4 * Fixed dp values * Minor fixes * Fixed dp * Fixed ProfileTestHelper * Added avatar color support. * Added Ben's createTimer * Addressed comments in previous PRs that didn't get pushed before. * Removed lines * Added admin pin creation flow * Fixed tests * Merge branch 'profile-avatar-colors' into profile-admin-flow * Added back button dialog to home activity * Initial changes, fragments to activities * Added basic recyclerview * Added recyclerview databinding * added new line * Initial profile read * Updated log statement * Added edit UI * Finished profile updating * Updated domain test case * Added AdminPinTests * Removed unused imports * Finished test cases * Finished rest of tests * Removed imports * Updated ResetPinActivity to include isAdmin * Cleaner profile avatar design * Updated profile:src * Removed textUtils * Updated profile edit avatar src * Reverted splash activity * Removed unused imports * Updated to now store colorHex and other fixes. * Updated comment. * Updated to colorRgb * Added fixes * Updated to force admin. * Updated comments. * Nit fixes. * Nit fixes.
|
This appears complete with the most recent PRs submitted. |
BenHenning
moved this to Needs Triage
in [Team] Developer Workflow & Infrastructure - Android
BenHenning
added
the
Z-ibt
BenHenning
modified the milestones:
Minimal Viable Product,
0.3 Release Blockers (Prototype MR3) -- MR1/MR2 fast-follows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A profile system needs to be implemented satisfying the requirements described in the Oppia PRD. This system should support storing a context of the currently logged-in profile, and support logging out that profile or logging in another profile. This system is responsible for the pin-based authentication described in the PRD.
Other systems might need to be updated to rely on this context rather than requiring a profile ID to be passed in to simplify them.
Note that for the prototype, it's essential that at least some portion of this system be implemented even if it just defaults to a single user without support for profile switching. Supporting profiles plays a central role in the design for the entire app architecture, so adding it late will be complex.
The text was updated successfully, but these errors were encountered: