Fixes part of #16: Implement ProfileEditActivity, ProfileRenameActivity, and ProfileResetPinActivity in settings [Blocked #22, #48] #543

jamesxu0 · 2019-12-11T01:47:08Z

Explanation

Implement ProfileEditActivity, ProfileRenameActivity, and ProfileResetPinActivity in settings [Blocked #22, #48]. Because of issue #322, I had to use startActivity() instead of finish() to return to previous activities to force livedata to update. Note the base branch is PR #542.

Checklist

The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
The PR follows the style guide.
The PR does not contain any unnecessary auto-generated code from Android Studio.
The PR is made from a branch that's not called "develop".
The PR is made from a branch that is up-to-date with "develop".
The PR's branch is based on "develop" and not on any other branch.
The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

…ment-controller

…-profile-chooser-fragment

BenHenning · 2019-12-11T03:10:08Z

@rt4914 deferring to you for the initial pass since I ran out of time to look at PRs today.

app/src/main/java/org/oppia/app/settings/profile/ProfileRenameActivityPresenter.kt

app/src/sharedTest/java/org/oppia/app/settings/profile/ProfileEditActivityTest.kt

app/src/main/java/org/oppia/app/settings/profile/ProfileResetPinActivityPresenter.kt

app/src/main/java/org/oppia/app/splash/SplashActivity.kt

app/src/main/res/values/strings.xml

rt4914

LGTM

app/src/main/java/org/oppia/app/databinding/ImageViewBindingAdapters.kt

app/src/main/java/org/oppia/app/databinding/TextViewBindingAdapters.kt

app/src/main/res/values/strings.xml

jamesxu0 added 30 commits October 23, 2019 10:34

implemented get and delete

0b1fb2a

Finished test cases

dac9b0a

added observing cachestore

a4b46e5

Fixed test cases

9c2f6a8

Merge branch 'implement-directory-util' into Implement-profile-manage…

53b5e78

…ment-controller

Finished first draft of implementation

ab2c396

Added additional checks to setCurrentProfileId

b4f8e1f

Added more test cases

36e4ac9

Finished test stubs

0309848

Finished test cases

2be5883

Merge branch 'develop' into Implement-profile-management-controller

1b52ae3

Added query string to gravatar

509479b

primed cache on init

74c59a8

Fixed typo

bb28e07

Fixed addProfile test case

087cc0e

added create method to PersistentCacheStore

650bbbc

added setTimestamp and setAdmin

af182a3

Merge branch 'develop' into Implement-profile-management-controller

ad952ec

changed isAdmin to default to false

71710f1

Added update last logged in

e1b8331

Started working on chooser

593f564

debugging

48d600e

Added UI for chooser

6a9e197

added click functionality

b3a4641

Minor fixes

0c23eaa

Started basic admin auth and add profile

b5cabbc

Updated to use deferred value from persistentCacheStore

f5d854c

Merge branch 'Implement-profile-management-controller' into implement…

3bbd5b7

…-profile-chooser-fragment

Updated to use login

756a759

Ensured result is error to post error value

bc477f0