Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paused activity does not get LiveData update onResume #322

Closed
Tracked by #3610
jamesxu0 opened this issue Nov 8, 2019 · 3 comments
Closed
Tracked by #3610

Paused activity does not get LiveData update onResume #322

jamesxu0 opened this issue Nov 8, 2019 · 3 comments
Assignees
@viktoriias @BenHenning
Labels
Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@jamesxu0
Copy link
Contributor

jamesxu0 commented Nov 8, 2019

In ProfileActivity, ProfileChooserFragment's list of profiles does not get updated when returning to the activity when another activity updates ProfileDatabase.
@jamesxu0 jamesxu0 added Type: Bug Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. labels Nov 8, 2019
This was referenced Dec 11, 2019
Merged
Closed
@veena14cs veena14cs mentioned this issue Jan 2, 2020
Closed
8 tasks
@rt4914 rt4914 mentioned this issue Feb 14, 2020
Merged
8 tasks
@BenHenning BenHenning added this to the Beta milestone Jun 23, 2020
@BenHenning BenHenning mentioned this issue Aug 27, 2020
Merged
8 tasks
@BenHenning
Copy link
Member

FYI I'm pretty sure this issue shouldn't happen with the new CoroutineLiveData that we're using, but this needs verification from someone.

@viktoriias
Copy link
Contributor

I tried reproducing this issue as described in #544:

To reproduce, click the "Add Profile" button and enter the admin PIN. Enter a name and click create. The profile will not be shown in the ProfileChooserFragment. If the app is restarted the new profile will be displayed.

Newly added profile is shown in the ProfileChooserFragment without needing to restart the app. It is also shown after the restart.

@BenHenning
Copy link
Member

Cool, I think that means that the replacement NotifiabelAsyncLiveData fixed this (or some other change).

This was referenced Jul 29, 2021
Merged
Merged
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@viktoriias viktoriias

@BenHenning BenHenning

Labels
Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Developer Workflow & Infrastructure - Android
Archived in project
Milestone
No milestone
Development

No branches or pull requests
5 participants
@MohamedMedhat1998 @viktoriias @BenHenning @anandwana001 @jamesxu0