Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigating #322: LiveData Bug (DO NOT MERGE) #544

Closed
wants to merge 1 commit into from

Conversation

jamesxu0
Copy link
Contributor

@jamesxu0 jamesxu0 commented Dec 11, 2019

Explanation

Investigating #322: LiveData Bug (DO NOT MERGE). This branch was made to investigate the LiveData bug where an activity in the background does not get LiveData updates when resuming the activity. To reproduce, click the "Add Profile" button and enter the admin PIN (12345). Enter a name and click create. The profile will not be shown in the ProfileChooserFragment. If the app is restarted the new profile will be displayed.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@BenHenning
Copy link
Member

Given that this isn't fixing anything and was part of an investigation, closing this since it's not intended to be merged (@jamesxu0 please let me know if you meant to keep this open).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants