Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #545: Low fi onboarding part 1 #558

Merged
merged 38 commits into from
Feb 19, 2020
Merged

Fix #545: Low fi onboarding part 1 #558

merged 38 commits into from
Feb 19, 2020

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Dec 16, 2019 •
edited
Loading

Explanation

Mock: https://xd.adobe.com/spec/e2239cf4-9cde-4c08-5296-25316c1f0a14-9412/screen/5981ecd6-2a80-4d82-8715-3e92294d53b5/RG-OB-Onboarding-1-

This PR implements the onboarding flow for new learners.

onboarding_flow

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@BenHenning
Copy link
Member

I didn't review it in full yet, but can you first upload a recording of the new flow? It'd be good to see it context to reference it as part of the review.

@BenHenning
Copy link
Member

@rt4914 feel free to follow up with me via chat if you want to discuss the solution proposed here in more detail.

@BenHenning BenHenning assigned rt4914 and unassigned BenHenning Dec 17, 2019
@rt4914
Copy link
Contributor Author

rt4914 commented Dec 17, 2019

@rt4914 feel free to follow up with me via chat if you want to discuss the solution proposed here in more detail.

@BenHenning I have just updated the PR description to include gif. But let's wait for for @veena14cs and @nikitamarysolomanpvt 's review and meanwhile I will try to check your comment and apply accordingly.

veena14cs
veena14cs approved these changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@veena14cs veena14cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides PTAL at some comments.

@veena14cs veena14cs removed their assignment Dec 17, 2019
nikitamarysolomanpvt
nikitamarysolomanpvt reviewed Dec 17, 2019
View reviewed changes
Copy link
Contributor

@nikitamarysolomanpvt nikitamarysolomanpvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think if sliders and indicators are dynamic would be better,Please see the comments and assign me back once new implementation changes are done

app/src/sharedTest/java/org/oppia/app/onboarding/OnboardingFragmentTest.kt Show resolved Hide resolved
app/src/sharedTest/java/org/oppia/app/onboarding/OnboardingFragmentTest.kt Outdated Show resolved Hide resolved
app/src/sharedTest/java/org/oppia/app/onboarding/OnboardingFragmentTest.kt Outdated Show resolved Hide resolved
@nikitamarysolomanpvt nikitamarysolomanpvt removed their assignment Dec 17, 2019
@nikitamarysolomanpvt nikitamarysolomanpvt removed their assignment Jan 13, 2020
@rt4914
Copy link
Contributor Author

rt4914 commented Feb 14, 2020

@veena14cs @nikitamarysolomanpvt for testing this, you will need to open the app, finish the onboarding flow, close the app completely and then again open it, it should show profile activity in second attempt.

You need to close the app completely because of issue number #322

@rt4914 rt4914 mentioned this pull request Feb 14, 2020
Closed
8 tasks
@rt4914 rt4914 changed the base branch from develop to domain-onboarding-flag-part-2 February 14, 2020 07:24
@rt4914 rt4914 changed the base branch from domain-onboarding-flag-part-2 to develop February 14, 2020 07:25
@rt4914 rt4914 assigned BenHenning and veena14cs and unassigned veena14cs Feb 18, 2020
@rt4914 rt4914 mentioned this pull request Feb 19, 2020
Closed
8 tasks
@rt4914 rt4914 assigned rt4914 and unassigned BenHenning Feb 19, 2020
@rt4914 rt4914 merged commit d705580 into develop Feb 19, 2020
@rt4914 rt4914 deleted the low-fi-onboarding-part-1 branch February 19, 2020 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikitamarysolomanpvt nikitamarysolomanpvt nikitamarysolomanpvt approved these changes

@BenHenning BenHenning BenHenning left review comments

@veena14cs veena14cs veena14cs approved these changes

Assignees

@rt4914 rt4914

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rt4914 @BenHenning @veena14cs @nikitamarysolomanpvt