Fixes part of #16: Implementation of AdminAuthActivity and AddProfileActivity #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-profile-chooser-fragment
…-profile-chooser-fragment
BenHenning
approved these changes
Nov 27, 2019
There was a problem hiding this comment.
I skimmed through the Kotlin portions, but didn't look at the XML files in detail. Otherwise, I defer to @rt4914 for verifying the UI structural & correctness aspects of this PR.
Please let me know & reassign to me if you'd like me to look at anything specific.
app/src/main/java/org/oppia/app/profile/AddProfileActivityPresenter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/oppia/app/profile/AddProfileActivityPresenter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/oppia/app/profile/AddProfileActivityPresenter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/oppia/app/profile/AdminAuthActivityPresenter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/oppia/app/profile/ProfileActivityPresenter.kt
Outdated
Show resolved
Hide resolved
…-profile-chooser-fragment
…-profile-chooser-fragment
…-profile-chooser-fragment
29 tasks
8 tasks
10 tasks
…-profile-chooser-fragment
jamesxu0
changed the base branch from
implement-profile-chooser-fragment
to
develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Fixes part of #16: Implementation of AdminAuthActivity and AddProfileActivity. It also implements a custom ProfileInputView to easily display error messages. Note the base branch is not develop but refers to PR #326.
Checklist