Fix #377: Control submit button #418
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we address this via data binding and the top level view model, instead? See https://github.com/oppia/oppia-android/blob/develop/app/src/main/java/org/oppia/app/player/state/StateViewModel.kt#L33 We ought to not have classes directly depend their parents. We could use listeners to indirect this, but there may be a cleaner reactive solution possible. |
veena14cs
reviewed
Nov 22, 2019
| import org.oppia.app.player.state.answerhandling.InteractionAnswerHandler | ||
| import org.oppia.app.player.state.answerhandling.InteractionAnswerReceiver | ||
|
|
||
| /** ViewModel for multiple or item-selection input choice list. */ | ||
| class SelectionInteractionViewModel( | ||
| val explorationId: String, interaction: Interaction, private val interactionAnswerReceiver: InteractionAnswerReceiver, | ||
| existingAnswer: InteractionObject?, val isReadOnly: Boolean | ||
| existingAnswer: InteractionObject?, val isReadOnly: Boolean, @Suppress("UNUSED_PARAMETER") stateFragmentPresenter: StateFragmentPresenter |
There was a problem hiding this comment.
use cmd+option+L to wrap this.
veena14cs
suggested changes
Nov 22, 2019
29 tasks
|
Closing this PR as this will be done once |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR controls the styling of "Submit " button.
Startbutton ofTopicTrainTab)Also, I have found one issue while working on this PR which has been mentioned in #417
Checklist