Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Numerator/denominator concept card should have images at the bottom #428

Closed
BenHenning opened this issue Nov 20, 2019 · 5 comments
Closed

Numerator/denominator concept card should have images at the bottom #428

BenHenning opened this issue Nov 20, 2019 · 5 comments
Assignees
@vinitamurthi
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Milestone
0.4 Release Block...

Comments

@BenHenning
Copy link
Member

No description provided.

@BenHenning
Copy link
Member Author

Hey James. Sean mentioned that you might have an idea on how to fix this?

@seanlip
Copy link
Member

seanlip commented Nov 20, 2019

More specifically -- @jamesxu0, I seem to remember you showed me once a concept card with two images at the bottom. Similar to this one? https://www.oppia.org/explore/xHwiGtvK2N4L

@BenHenning BenHenning assigned vinitamurthi and unassigned jamesxu0 Nov 30, 2019
@BenHenning
Copy link
Member Author

@vinitamurthi James has a bunch of questions & audio work to complete early next week. Might you be able to look at this?

@BenHenning BenHenning mentioned this issue Nov 30, 2019
Closed
29 tasks
@vinitamurthi
Copy link
Contributor

Not 100% sure I understood this one..Do we want to have a concept card where the HTML content has image tags? Is that what we are going for?

@BenHenning BenHenning added this to the Alpha milestone Jun 23, 2020
@BenHenning BenHenning added Type: Bug Priority: Essential This work item must be completed for its milestone. and removed Workstream: Finalize Prototype pt2 (20-30 Nov) labels Jun 23, 2020
@BenHenning
Copy link
Member Author

I suspect this issue will go/has gone away with the full implementation of subtopic cards & proper data being imported into the app.

@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vinitamurthi vinitamurthi

Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
0.4 Release Blockers (Alpha MR1)
Development

No branches or pull requests
4 participants
@seanlip @vinitamurthi @BenHenning @jamesxu0