Fix part #376: Fraction input interaction view validation #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…://github.com/oppia/oppia-android into hi-fi-input-interaction-views # Conflicts: # app/src/main/res/layout/text_input_interaction_item.xml
…://github.com/oppia/oppia-android into hi-fi-input-interaction-views # Conflicts: # app/src/main/res/layout/text_input_interaction_item.xml
… hi-fi-input-interaction-views
On click of input type interaction item, it requires two clicks to display keyboard, which should actually be just a single click. thus preventing scroll due to edit text focus
…ToPosition(0) in processEphemeralStateResult
…://github.com/oppia/oppia-android into hi-fi-input-interaction-views
…hould be larger than 7 digits."
|
@nikitamarysolomanpvt I have checked your last commits they look fine to me. I will need to defer to @veena14cs on this PR. |
|
LGTM |
BenHenning
approved these changes
Jan 21, 2020
There was a problem hiding this comment.
Thanks! This looks fantastic. Sorry for the long review--once my comments are addressed feel free to submit this.
Also, did you reach out to someone on the Oppia web team to discuss implementing the new 7-digit error on there? (FYI @seanlip).
app/src/main/java/org/oppia/app/parser/StringToFractionParser.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/oppia/app/player/state/StateFragmentPresenter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/oppia/app/player/state/answerhandling/InteractionAnswerErrorReceiver.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/oppia/app/player/state/listener/StateKeyboardButtonListener.kt
Outdated
Show resolved
Hide resolved
|
nikitamarysolomanpvt
deleted the
hi-fi-input-interaction-views-validation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Added validation for fraction input with error messages given below.
INVALID_CHARS = "Please only use numerical digits, spaces or forward slashes (/)"
INVALID_FORMAT = "Please enter a valid fraction (e.g., 5/3 or 1 2/3)"
DIVISION_BY_ZERO = "Please do not put 0 in the denominator"
For testing purpose make following change in code:
Launcher activity should be InputInteractionViewTestActivity
Design Doc
https://docs.google.com/document/d/1QigNdZeMBy-JjHW26QH4qT0UtCyzfvW0xEaStSdY9gM/edit#heading=h.2i0txgpugkgf
Reference
https://www.oppia.org/explore/rfX8jNkPnA-1?collection_id=4UgTQUc1tala
Checklist