Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full UI: EndExplorationInteractionView [Blocked: #15, #157] #35

Closed
2 tasks
BenHenning opened this issue Aug 2, 2019 · 5 comments
Closed
2 tasks

Full UI: EndExplorationInteractionView [Blocked: #15, #157] #35

BenHenning opened this issue Aug 2, 2019 · 5 comments
Assignees
@rt4914
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Milestone
0.4 Release Block...

Comments

@BenHenning
Copy link
Member

BenHenning commented Aug 2, 2019 •
edited by rt4914
Loading

This is tracking implementing the fully polished UI version of the end exploration interaction.

See the web frontend for details on how the end exploration interaction works.

Mock: https://xd.adobe.com/spec/e2239cf4-9cde-4c08-5296-25316c1f0a14-9412/screen/40d6cf5f-f673-42c8-af15-035f711ef6b9/PM-IN-Introduction-

Checklist

  • Return to Topic Button

Screenshot 2019-11-08 at 3 51 33 PM

  • Final touch up with padding, margin, animations and Accessibility Scanner test
@BenHenning BenHenning added Type: Improvement Priority: Essential This work item must be completed for its milestone. labels Aug 2, 2019
@BenHenning BenHenning added this to the Prototype milestone Aug 2, 2019
@BenHenning
Copy link
Member Author

This is blocked on #28 to introduce the general interaction architecture. This also likely is not needed for practice sessions since it's exploration-specific, or it needs to be generalized to handle the end of both explorations and practice sessions (or we need a separate interaction to handle the practice sessions case).

@BenHenning BenHenning mentioned this issue Aug 2, 2019
Open
@BenHenning BenHenning changed the title End Exploration End Exploration [Blocked: #28] Aug 12, 2019
@BenHenning BenHenning mentioned this issue Sep 20, 2019
Closed
@BenHenning BenHenning changed the title End Exploration [Blocked: #28] Full UI: EndExplorationInteractionView [Blocked: #15, #157] Sep 20, 2019
@BenHenning
Copy link
Member Author

This is blocked on #15 for a full domain controller implementation and #157 for the initial structure introduction for this interaction.

@rt4914 rt4914 self-assigned this Sep 20, 2019
@BenHenning BenHenning mentioned this issue Sep 20, 2019
Merged
6 tasks
@rt4914 rt4914 assigned rt4914 and unassigned rt4914 Sep 23, 2019
@rt4914 rt4914 removed their assignment Oct 7, 2019
@rt4914 rt4914 self-assigned this Oct 29, 2019
@BenHenning
Copy link
Member Author

@rt4914 can you clarify what remaining work needs to be done here?

@BenHenning BenHenning mentioned this issue Nov 30, 2019
Closed
29 tasks
@rt4914
Copy link
Contributor

rt4914 commented Dec 2, 2019

The UI is ready but the final implementation depends on #377

@rt4914
Copy link
Contributor

rt4914 commented Aug 17, 2020

Closed via #1653

@rt4914 rt4914 closed this as completed Aug 17, 2020
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rt4914 rt4914

Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
0.4 Release Blockers (Alpha MR1)
Development

No branches or pull requests
2 participants
@rt4914 @BenHenning