Fix #387: Add support for showing concept cards in explorations [BLOCKED ON MISSING TESTS] #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
card as one of the remediation pathways for 'the meaning of equal parts' lesson.
|
@jamesxu0 can you take a look at this? |
jamesxu0
approved these changes
Nov 27, 2019
This was referenced Nov 30, 2019
|
Hi @BenHenning. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks! |
|
Replaced by #731. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #387.
This introduces support for showing custom Oppia concept card links in feedback and content HTML. This requires a custom content handler with some hacky tag injection, but this seems like the best we can do (see https://stackoverflow.com/a/36528149 for context).
This updates the 'meaning of equal parts' exploration to include this new tag. This isn't yet finished on Oppia backend (FYI @aks681), so what we're working with in the meantime is a tag of the sort: refresher lesson.
This PR is ready for review, but not submission yet since tests need to be written.