Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #425: Update HasNumeratorEqualTo classifier to match the parsing logic #510

Merged
merged 1 commit into from
Dec 4, 2019

Conversation

BenHenning
Copy link
Member

@BenHenning BenHenning commented Dec 4, 2019

Fix #425.

This was missed as part of #450: we updated the type being parsed but not the corresponding classifier. HasDenominatorEqualTo does not have the same since it's already using the correct type.

@BenHenning BenHenning changed the title Update HasNumeratorEqualTo classifier to match the parsing logic Fix #425: Update HasNumeratorEqualTo classifier to match the parsing logic Dec 4, 2019
@BenHenning BenHenning requested a review from seanlip December 4, 2019 09:31
@seanlip seanlip merged commit 34140c1 into develop Dec 4, 2019
@seanlip seanlip deleted the fix-fraction-rule-type branch December 4, 2019 10:16
Copy link
Contributor

@nikitamarysolomanpvt nikitamarysolomanpvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikitamarysolomanpvt nikitamarysolomanpvt removed their assignment Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sometimes fraction input doesn't let you submit
5 participants