Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish cellular functionality for audio streaming #307

Closed
BenHenning opened this issue Nov 5, 2019 · 1 comment · Fixed by #358
Closed

Finish cellular functionality for audio streaming #307

BenHenning opened this issue Nov 5, 2019 · 1 comment · Fixed by #358
Assignees
@jamesxu0
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@BenHenning
Copy link
Member

BenHenning commented Nov 5, 2019 •
edited
Loading

The cellular audio button does not actually detect whether the user is currently on cellular, and it attempts to play audio even if explorations don't have voiceovers. We should also overall make sure the voiceover flows work correctly in the exploration player once #270 is done.
@BenHenning BenHenning added Priority: Essential This work item must be completed for its milestone. Status: Not started labels Nov 5, 2019
@BenHenning BenHenning changed the title Finish cellular functionality Finish cellular functionality for audio streaming Nov 6, 2019
@jamesxu0 jamesxu0 mentioned this issue Nov 15, 2019
Merged
8 tasks
@BenHenning BenHenning removed their assignment Nov 16, 2019
@BenHenning
Copy link
Member Author

There also seems to be a lot of bugs around continuing audio in follow-up states. I'm seeing repeated crashes along the lines of:

    java.lang.IllegalStateException: Media Player not in a prepared state

We should make sure that audio properly starts/stops in subsequent states, that it fails gracefully when there's no internet access, and that the button only appears when there's audio to stream and the user has internet connectivity.

We should also make sure that feedback audio is automatically played when feedback is given, and replaying the audio for a state replays its content in the same way as it does on Oppia web.

@BenHenning BenHenning mentioned this issue Nov 30, 2019
Closed
29 tasks
jamesxu0 added a commit that referenced this issue Dec 13, 2019
@jamesxu0
Fixes #307: Finish cellular functionality for audio streaming (#358)
3189cae 
* Finished audio functionality for statefragment

* moved audio fragment to top

* Added test cases to NetworkConnectionUtil

* Added remove audiofragment animation

* moved exploration retrieval to AudioViewModel

* Added no audio available

* Changed NetworkConnectionUtil for tests

* new audio test cases, removed old ones

* Fixed tests

* Fixed comment

* Fixed rotation case

* Removed unused methods and imports

* Added feedback playback

* Added autoplay

* Always add audio fragment

* Working on test cases

* Added exploration tests and fixed not showing exploration title

* Added more test cases

* Do not auto play audio when language selection is shown

* Fixed test case

* Minor fixes

* Changed AudioUIManger API

* Moving code to audioFragmentPresenter (WIP).

* Removed audio code from statefragment

* Added annotations to test

* Minor changes

* Routed setVisibility to activity

* Added scrollToTop.

* Updated AudioUiManager
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamesxu0 jamesxu0

Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #307: Finish cellular functionality for audio streaming oppia/oppia-android
2 participants
@BenHenning @jamesxu0