-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audio Content highlight [DO NOT MERGE] #491
Conversation
This is nice :) But, when there are multiple parts to be spoken on a page (like the feedback after you submit an answer), does the highlight move accordingly? |
Yes it will. The logic is that the highlight is dependent on contentId that we get from AudioPlayer, so only the corresponding contentId will get highlighted. But, I still believe if we have a exploration in which we can test this thoroughly, it will be good. @BenHenning any suggestions on any such exploration. |
You could just use the fractions "equal parts" lesson and submit some wrong answers, right? |
I did check that it does have everything that we need. But there is one issue, I believe in current audioplayer only first audio is getting played and others are not getting played. Unless, others are not played, we cannot check if this PR works perfectly or not. @jamesxu0 @BenHenning does Audio player handles multiple audios corresponding to different contentId in same state? If so, then how can we play those multiple audios? |
After detailed checking, I have found that, unless and until, multiple audios are not played in same state, this PR won't work. Currently it will fail. |
Once #358 is checked in the audio player should properly switch audio focus between different content IDs in the same state. |
Please re-assign back to me when this is ready to review. |
This is a great design. What color did you use for the border? I want to make sure I have a copy of this on my mocks. Otherwise LGTM. |
Please assign back to me once it ready for review. |
Highlighting works nice. But we need to test with other states as discussed in this thread. Assign back once it is ready. |
This PR has been recreated on #514 which solves all the issues mentioned in this PR. |
Explanation
This PR function in following way:
If you play audio, the content-card corresponding to it will get highlighted.
If you play audio, the content-card corresponding to it will come to normal.
Checklist