Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio Content highlight [DO NOT MERGE] #491

Closed
wants to merge 1 commit into from

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Nov 29, 2019

Explanation

This PR function in following way:
If you play audio, the content-card corresponding to it will get highlighted.
If you play audio, the content-card corresponding to it will come to normal.

audio-content

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@seanlip
Copy link
Member

seanlip commented Nov 30, 2019

This is nice :) But, when there are multiple parts to be spoken on a page (like the feedback after you submit an answer), does the highlight move accordingly?

@seanlip seanlip assigned rt4914 and unassigned seanlip Nov 30, 2019
@rt4914
Copy link
Contributor Author

rt4914 commented Nov 30, 2019

This is nice :) But, when there are multiple parts to be spoken on a page (like the feedback after you submit an answer), does the highlight move accordingly?

Yes it will. The logic is that the highlight is dependent on contentId that we get from AudioPlayer, so only the corresponding contentId will get highlighted.

But, I still believe if we have a exploration in which we can test this thoroughly, it will be good. @BenHenning any suggestions on any such exploration.

@seanlip
Copy link
Member

seanlip commented Nov 30, 2019

You could just use the fractions "equal parts" lesson and submit some wrong answers, right?

@rt4914
Copy link
Contributor Author

rt4914 commented Nov 30, 2019

You could just use the fractions "equal parts" lesson and submit some wrong answers, right?

I did check that it does have everything that we need. But there is one issue, I believe in current audioplayer only first audio is getting played and others are not getting played. Unless, others are not played, we cannot check if this PR works perfectly or not.

@jamesxu0 @BenHenning does Audio player handles multiple audios corresponding to different contentId in same state? If so, then how can we play those multiple audios?

@rt4914
Copy link
Contributor Author

rt4914 commented Nov 30, 2019

This is nice :) But, when there are multiple parts to be spoken on a page (like the feedback after you submit an answer), does the highlight move accordingly?

After detailed checking, I have found that, unless and until, multiple audios are not played in same state, this PR won't work. Currently it will fail.

@rt4914 rt4914 changed the title Audio Content highlight Audio Content highlight [ON HOLD - NEED CLARIFICATION] Nov 30, 2019
@rt4914 rt4914 removed their assignment Nov 30, 2019
@BenHenning
Copy link
Member

Once #358 is checked in the audio player should properly switch audio focus between different content IDs in the same state.

@BenHenning
Copy link
Member

Please re-assign back to me when this is ready to review.

@BenHenning BenHenning removed their assignment Dec 2, 2019
@mschanteltc
Copy link

This is a great design. What color did you use for the border? I want to make sure I have a copy of this on my mocks. Otherwise LGTM.

@nikitamarysolomanpvt
Copy link
Contributor

Please assign back to me once it ready for review.

@nikitamarysolomanpvt nikitamarysolomanpvt removed their assignment Dec 2, 2019
@veena14cs
Copy link
Contributor

Highlighting works nice. But we need to test with other states as discussed in this thread. Assign back once it is ready.

@veena14cs veena14cs removed their assignment Dec 2, 2019
@rt4914 rt4914 changed the title Audio Content highlight [ON HOLD - NEED CLARIFICATION] Audio Content highlight [BLOCKED ON PR #358] Dec 2, 2019
@rt4914 rt4914 changed the title Audio Content highlight [BLOCKED ON PR #358] Audio Content highlight [DO NOT MERGE] Dec 4, 2019
@rt4914
Copy link
Contributor Author

rt4914 commented Dec 4, 2019

This PR has been recreated on #514 which solves all the issues mentioned in this PR.

@rt4914 rt4914 closed this Dec 4, 2019
@BenHenning BenHenning deleted the hifi-audio-content-card branch June 10, 2020 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants