-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix part of #494: Audio Content highlighting #514
Conversation
@vinitamurthi @seanlip @mschanteltc @BenHenning @veena14cs @nikitamarysolomanpvt @jamesxu0 I believe that the points that I have mentioned in the description are up for discussion which lies in web domain and UX domain. Feel free to comment your suggestions. The main question is should we highlight all the content cards in case of repetition or only the last card. |
Let's highlight only the last card. Just wondering, is there a feature where the user can scroll up, tap a previous card, and listen to the audio of that? Also will the scrub's cursor start at the beginning if it plays audio of a different card? We should implement this in the use case where the user answers the question incorrectly multiple times, making the time range of the scrub excessively long. |
@mschanteltc
|
"Scrub" means to drag the audio pointer horizontally along the bar. (And @mschanteltc -- yes, the scrub starts at the beginning when the user goes to a new card.) |
Thanks @rt4914.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Conflicts: app/src/main/java/org/oppia/app/player/state/StateFragmentPresenter.kt
FYI that I'm merging this. We should resolve what we want to do from the UX/product side before finishing this work on develop. |
Explanation
This PR code is hard to check completely because half of the code was in #491 and other half of code is in this PR. This has happened because @BenHenning had to merge #491 in
temp-integration-pt3
but that code was not 100% correct. So to test this PR, we should mainly focus on content highlighting in each and every possible case.Also, there can be cases in which same content is getting displayed again and again, in that case on playing audio only the last card will be highlighted to keep it clean.
Also, in web, it is highlighting all the cards if the cards are repetitive, I have filed an issue for that on oppia/oppia#8127
Checklist