Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audio based Content Item highlighting in StateFragment #1383

Open
rt4914 opened this issue Jun 22, 2020 · 4 comments
Open

Audio based Content Item highlighting in StateFragment #1383

rt4914 opened this issue Jun 22, 2020 · 4 comments
Labels
enhancement End user-perceivable enhancements. Impact: Low Low perceived user impact (e.g. edge cases). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@rt4914
Copy link
Contributor

rt4914 commented Jun 22, 2020

This issue is tracker the work of Audio based content card highlighting which was previously done in #514 but with new ExplorationPlayer and QuestionPlayer it needs to be implemented again.

The final output should look something like this:
Screenshot_1575461301
Screenshot_1575461307
@rt4914 rt4914 self-assigned this Jun 22, 2020
@rt4914 rt4914 added Priority: Essential This work item must be completed for its milestone. Where: Exploration player Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. and removed Where: Starting flows labels Jun 22, 2020
@rt4914 rt4914 added this to the Alpha milestone Jun 22, 2020
@rt4914 rt4914 mentioned this issue Jun 22, 2020
Closed
16 tasks
This was referenced Jun 24, 2020
Closed
Closed
@BenHenning
Copy link
Member

Since this more of a nice-to-have, pushing to beta.

@BenHenning BenHenning modified the milestones: Alpha, Beta Aug 20, 2020
@justdvnsh
Copy link
Contributor

justdvnsh commented Mar 21, 2021 •
edited
Loading

@rt4914 Okay, So I have found a solution for this issue. It is based on your PR which I took for reference #1384 . I have committed the code, as for now (justdvnsh@7f74425). This is solving all the issues, except one edge case, which is not a very important one, yet I think I can solve it, with a little bit of help.

I am also attaching a video as a POC. (https://drive.google.com/file/d/1w81SKafbCgszq0f9PJRZuARkEooYbREv/view?usp=sharing)

Also, while working on this issue, I found out an issue, which I think can be a good first or good second issue. (If there is no internet connection, and we try to run the audio voiceover, it would result it an unexpected crashing of the app.)

@rt4914
Copy link
Contributor Author

rt4914 commented Mar 22, 2021

@justdvnsh Create a PR so that I can easily check it.
Also, whatever issue you have identified, file a bug for that and cc me to cross verify. Thanks

@justdvnsh justdvnsh mentioned this issue Mar 24, 2021
Closed
8 tasks
@justdvnsh
Copy link
Contributor

@rt4914 Create a PR as you asked.

@rt4914 rt4914 removed their assignment Nov 17, 2021
@bhaktideshmukh bhaktideshmukh mentioned this issue May 5, 2022
Closed
6 tasks
@BenHenning BenHenning modified the milestones: Beta, Beta MR1, Beta MR2 Jun 11, 2022
@Broppia Broppia added issue_type_bug Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). labels Jul 29, 2022
@BenHenning BenHenning added Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Z-ibt Temporary label for Ben to keep track of issues he's triaged. issue_user_learner labels Sep 15, 2022
@BenHenning BenHenning removed this from the Beta MR2 milestone Sep 16, 2022
@seanlip seanlip added bug End user-perceivable behaviors which are not desirable. and removed issue_user_learner labels Mar 29, 2023
@adhiamboperes adhiamboperes added enhancement End user-perceivable enhancements. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Impact: Low Low perceived user impact (e.g. edge cases). and removed Priority: Essential This work item must be completed for its milestone. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. bug End user-perceivable behaviors which are not desirable. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). labels Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement End user-perceivable enhancements. Impact: Low Low perceived user impact (e.g. edge cases). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Status: Todo
Milestone
No milestone
6 participants
@rt4914 @seanlip @BenHenning @justdvnsh @adhiamboperes @Broppia