-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1383: added audio based content highlighting #2996
Conversation
…ycler view item based on the audio track playing.
@rt4914 I have created a PR as requested. Also, there is one problem in the code. However, rest everything seems to work just fine. Please take a look and tell me, so that I can make more improvements in this PR and also, clean up the code a little. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The approach is on the right track but there are a lot of edge cases that needs to be taken care of.
@rt4914 Okay. Would be working on it. |
@justdvnsh any update on this? |
@anandwana001 Yes. I will be working on this from tomorrow. Sorry, got a little busy due to the GSoC and internships !! |
@rt4914 Okay, so I am having a little issue here. Can you help me out a little. First part is okay (it can be solved using a binding adapter), but for the second part, there needs to be some way of highlighting only the last feedback item. Can you suggest me anything that can be done to resolve the 2nd part of this issue ? |
@justdvnsh Actually even I do not have any direct solution here because that's the same step I was stuck the last time. Do you have some approaches in mind? |
@justdvnsh any update on this? |
@anandwana001 Yup. I am stuck too on the step mentioned above. Trying to formulate a solution for now. |
@rt4914 Not
Not really Actually ! I tried a few things. But none of them seem to work |
@rt4914 PTAL |
Closing this PR as no further update. |
Explanation
Fix #1383: Added audio based content highlighting - to highlight the correct recyler view item based on the audio track playing
Checklist