-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weekly report script #50
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry if it's too early to review but this is exciting stuff!
- It'd be nice to have the
package.json
inside thejs/
folder as there's also apython/
directory at the same level. Keeps code that cannot interact with each other separated. - It'll also be cool to spin this off into a separate action and run it from our workflows. I think a lot more people can find it useful (and/or contribute to it) that way.
Some more feedback:
On a lighter note, this is beautiful. Getting some xkcd vibes. |
haha way to early to review this. I'm going to squash the commits. Also, it doesn't work—the api doesn't even allow the querying I want regarding close dates. |
Okay now it works @dhruvkb, filtering the issues by mapAwait(fetchRepoIssues)(repos)
.then(mapAwait(getJSON))
.then(map(filter(filterClosed)))
.then(zipObj(repos))
.then(compose(map(branch(logRepo, map(logIssue))), entries))
.catch(console.error) |
648243e
to
855b2d7
Compare
I had another idea! Can we get an API from WordPress and post this changelog to either the Team Openverse P2 or the Make site? That would give us something very close to a snaps post, but autogenerated. |
fetch(url, { | ||
headers: { | ||
Authorization: | ||
'Basic emFja2tyaWRhOmdocF9JVHdJM2ZGUkVqSjZkOWRBUFFBOE5pWktwNlU0dXkxRTVFak8=', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A key for is not needed for reading public resources.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is useful locally however, for the purpose of rate limiting. Maybe I'll make it an optional script input.
Yeah, we could definitely look at doing this for the "A Week in Openverse" make posts. The idea is that Snaps will be fewer, deeper looks at things, with a focus on the visual component, and the make post is more of a formal changelog. Sometimes I'd be nice to manually include some of the Snap information in the Make posts, so we could just edit the posts after our automation publishes them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, of course, if you've done cleaning up :)
Sure @zackkrida, I'll review it first thing tomorrow. Sorry to keep you waiting this long. |
No worries at all, I left you hanging on some answers! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me 👍. I love the functional utils! I think I'm going to keep a copy for some personal use.
We'll definitely refactor when the number of JS scripts increases and necessitates that.
Maybe I'll clean this up, maybe I won't 😆 written in a silly fp-lite style that I tend to write my own stuff in. Here's a sample output:
rendered:
openverse
openverse-frontend
description
meta tagopenverse-api
openverse-catalog
genre
property withgenres
in testswatermarked
column to audio loading table