Skip to content
This repository has been archived by the owner on Aug 4, 2023. It is now read-only.

Fix failing test, improve import readability #81

Merged
merged 1 commit into from
Jun 3, 2021
Merged

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Jun 3, 2021

Addition of the testing and linting workflows surfaced a couple of errors that were added in the last commit:

  • The test_raw_pixel.py had some changes from a different PR, which do not pass. The changes were reverted, and will be added in a different PR.
  • There was a duplicate import in raw_pixel.py script. I removed that, and added a blank line between the standard library and local package imports for readability.

Signed-off-by: Olga Bulat [email protected]

Revert changes to raw_pixel_tests to make them pass
Add a blank line between the standard library and local package imports for readability

Signed-off-by: Olga Bulat <[email protected]>
@obulat obulat requested review from dhruvkb, krysal and zackkrida June 3, 2021 07:07
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reversion of test_raw_pixel.py looks correct to me.

@obulat obulat merged commit 06e64b9 into main Jun 3, 2021
@obulat obulat deleted the fix_test_failures branch June 3, 2021 16:54
@zackkrida zackkrida added the 🛠 goal: fix Bug fix label Aug 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants