Skip to content
This repository has been archived by the owner on Aug 4, 2023. It is now read-only.

Fix pep8 violations #103

Merged
merged 4 commits into from
Jun 17, 2021
Merged

Fix pep8 violations #103

merged 4 commits into from
Jun 17, 2021

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Jun 9, 2021

Fixes WordPress/openverse#1731

This PR fixes the following problems with code quality in provider API scripts:

  • names shadowing built-ins (license)
  • variable that are used before they are declared
  • unused variables
  • unnecessary parentheses around tuples

This PR is a half of #67, split to make review easier. It also replaces #102
Signed-off-by: Olga Bulat [email protected]

Signed-off-by: Olga Bulat <[email protected]>
@obulat obulat requested a review from a team as a code owner June 9, 2021 10:43
@obulat obulat requested review from zackkrida and krysal June 9, 2021 10:43
Signed-off-by: Olga Bulat <[email protected]>
Signed-off-by: Olga Bulat <[email protected]>
@obulat obulat mentioned this pull request Jun 9, 2021
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@obulat obulat merged commit 0c7a507 into main Jun 17, 2021
@obulat obulat deleted the flake-8 branch June 17, 2021 13:59
@zackkrida zackkrida added the 🛠 goal: fix Bug fix label Aug 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Fix flake8 warnings
3 participants