This repository has been archived by the owner on Aug 4, 2023. It is now read-only.
[Quality] Code cleanup #67
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace mutable default function parameters - Make function names lower case - Refactor to remove variables that might be referenced before assignment - Add some type hinting - Remove unused variables and imports
The functions that use etlMods module cannot be tested at the moment, so the changes have been reversed
krysal
reviewed
May 28, 2021
Comment on lines
94
to
96
| def _handle_response( | ||
| batch | ||
| ): |
There was a problem hiding this comment.
The format of this param looks a bit odd here.
There was a problem hiding this comment.
Definitely! Thank you for catching this!
krysal
previously approved these changes
May 28, 2021
Comment on lines
+67
to
68
| response_json, total_images, tries = None, 0, 0 | ||
| for tries in range(retries): |
|
Apparently, the code problems fixed in this PR do cause errors when running the scripts using Airflow dags, like this: So, it is important to fix them. |
Signed-off-by: Olga Bulat <[email protected]>
This was referenced Jun 9, 2021
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes several types of code problems highlighted by Pycharm's code inspection.
Changes:
Replace mutable default parameters
Python creates a default parameter once when the function is defined. The same value is used every time the function is called. This causes a problem if the value is mutable, such as a dictionary or a list. If this value is ever changed inside the function, the changed value is used for subsequent function calls, instead of the default value.
Make function names lower case, separating words with underscores:
sanitize_stringinstead ofsanitizeStringRefactor to remove variables that might be referenced before assignment
Remove unused variables and imports
Add some type hinting