This repository has been archived by the owner on Aug 4, 2023. It is now read-only.
Ensure Docker loads local_postgres sql scripts in correct order #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olga Bulat <[email protected]>
dhruvkb
previously approved these changes
Jun 8, 2021
dhruvkb
reviewed
Jun 8, 2021
There was a problem hiding this comment.
I've sometimes observed people using a numbering convention of using 10s place for categories and 1s place for individual scripts, like
10_airflow_user_db.sql
20_aws_s3_mock.sql
31_openledger_image_schema.sql
32_openledger_image_view.sql
33_openledger_old_image_schema.sql
Similarly scripts for audio that come later would be 4x.
I'm just putting this idea out there, I'm not sure such a convention applies here.
|
Any additional zeroes are welcome 👍 |
To allow for future expansion Signed-off-by: Olga Bulat <[email protected]>
|
Great j000b, LGTM |
zackkrida
approved these changes
Jun 9, 2021
krysal
approved these changes
Jun 10, 2021
There was a problem hiding this comment.
Learning about that directory for initialization scripts in the postgres image, interesting! Looks good.
dhruvkb
approved these changes
Jun 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes WordPress/openverse#1735
This PR adds numbers to the
local_postgressql script names to ensure that Docker executes them in the correct order.This prepares us for adding audio db table by either adding it to the
openledger_image_schemaand renaming it toopenledger_media_schema, or creating a newopenledger_audio_schema.Signed-off-by: Olga Bulat [email protected]