Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon, logo and brand usage guidelines #44

Merged
merged 3 commits into from
Aug 11, 2021
Merged

Add icon, logo and brand usage guidelines #44

merged 3 commits into from
Aug 11, 2021

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Aug 11, 2021

Description

This PR adds brand assets (and some usage guidelines) for Openverse to the repository.

Technical details

Keeping the brand assets centralised is useful for

  • hotlinking from places that don't want to ship with a copy of the assets
  • sharing the assets with third-parties who want to depict their association to the project
  • making changes in one place instead of many, if need be

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb requested a review from a team as a code owner August 11, 2021 17:13
@dhruvkb dhruvkb requested review from zackkrida and obulat August 11, 2021 17:13
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What formatter is setting this markdown line width? This is otherwise fantastic work.

@dhruvkb
Copy link
Member Author

dhruvkb commented Aug 11, 2021

I think it's the one built into PyCharm. @zackkrida should I revert the line wrapping changes?

Edit: Yes, it is.
Screenshot 2021-08-11 at 10 53 01 PM

dhruvkb added a commit to WordPress/openverse-api that referenced this pull request Aug 11, 2021
@dhruvkb
Copy link
Member Author

dhruvkb commented Aug 11, 2021

Maybe later though, because merging this will unblock WordPress/openverse-api#170.

@dhruvkb dhruvkb merged commit 0b1670e into main Aug 11, 2021
@dhruvkb dhruvkb deleted the brand_assets branch August 11, 2021 17:28
@zackkrida
Copy link
Member

should I revert the line wrapping changes?

Please do @dhruvkb, another PR is fine. Thank you!

@zackkrida zackkrida mentioned this pull request Aug 14, 2021
dhruvkb pushed a commit that referenced this pull request Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants