Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Replace Bulma helpers with Tailwind utilities #99

Merged
merged 24 commits into from
Aug 11, 2021
Merged

Replace Bulma helpers with Tailwind utilities #99

merged 24 commits into from
Aug 11, 2021

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Jul 28, 2021 •
edited
Loading

Fixes #97

This PR replaces Bulma helpers with their Tailwind counterparts. After confirming that none of Bulma's helpers are in use, we can chuck the directory altogether.

@dhruvkb dhruvkb changed the base branch from main to tailwind July 28, 2021 07:53
@dhruvkb dhruvkb changed the title Install and scaffold Tailwind Replace Bulma helpers with Tailwind utilities Jul 28, 2021
@dhruvkb dhruvkb marked this pull request as ready for review July 28, 2021 10:44
@dhruvkb dhruvkb requested a review from a team as a code owner July 28, 2021 10:44
@dhruvkb dhruvkb requested review from zackkrida and obulat and removed request for a team July 28, 2021 10:44
@dhruvkb
Copy link
Member Author

dhruvkb commented Jul 28, 2021

There could be some variations due to specificity issues (Bulma's deeply nested classes in components mostly win over Tailwind 😢) but the PR seems to be in a good place. The specificity issues will likely be a recurring issue during the framework transition stage.

@dhruvkb
Copy link
Member Author

dhruvkb commented Jul 28, 2021

This PR will need updating when #96 is merged.

Base automatically changed from tailwind to main July 28, 2021 16:09
@dhruvkb
Copy link
Member Author

dhruvkb commented Jul 28, 2021

This is looking pretty good now, open for reviews!

@zackkrida
Copy link
Member

Awesome, I'm excited to explore the code here

zackkrida
zackkrida approved these changes Jul 30, 2021
View reviewed changes
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great, and actually makes me think we could have the old .scss removed before we implement the finalized UI. That would actually be quite nice, as it would give us more of a 'clean slate' before heavily modifying and creating new components.

@dhruvkb
Copy link
Member Author

dhruvkb commented Jul 30, 2021

I agree, it'll be awesome to be able to create the new components purely in Tailwind.

obulat
obulat approved these changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing all this work, Dhruv! The utility classes are much more organized now.

@dhruvkb dhruvkb merged commit 7668b19 into main Aug 11, 2021
@dhruvkb dhruvkb deleted the bulma_to_tw branch August 11, 2021 09:56
@zackkrida zackkrida added 🕹 aspect: interface Concerns end-users' experience with the software 🤖 aspect: dx Concerns developers' experience with the codebase labels Aug 12, 2021
@zackkrida zackkrida mentioned this pull request Aug 14, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@obulat obulat obulat approved these changes

@zackkrida zackkrida zackkrida approved these changes

Assignees
No one assigned
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🕹 aspect: interface Concerns end-users' experience with the software
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Replace utility classes with Tailwind
3 participants
@dhruvkb @zackkrida @obulat