Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Improve i18n pluralization for Russian #115

Merged
merged 1 commit into from
Aug 10, 2021
Merged

Improve i18n pluralization for Russian #115

merged 1 commit into from
Aug 10, 2021

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Aug 9, 2021

Description

Some languages have a more complex set of pluralization rules than 'use a plural form when a number is greater than 1'. The current i18n setup does not take this into account, and the Image Search Result page would have incorrect translation because of that.
This PR adds the pluralization rules for Russian to fix this. Even as a native speaker, my mind is blown by the complexity of the rules :)

Technical details

The pluralization function is called whenever we use $tc function of vue-i18n that chooses the correct plural noun in phrases with numbers.

Screenshots

Numbers ending with 2-4 require a different ending than the numbers ending with 5-9:
Screen Shot 2021-08-09 at 1 08 26 PM

Screen Shot 2021-08-09 at 1 09 17 PM

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat requested a review from a team as a code owner August 9, 2021 10:20
@obulat obulat requested review from zackkrida and krysal August 9, 2021 10:20
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Learning about the Russian pluralization rules was fun!

src/locales/en.json Show resolved Hide resolved
@obulat obulat merged commit 42a136f into main Aug 10, 2021
@obulat obulat deleted the plural branch August 10, 2021 15:08
@zackkrida zackkrida added ♿️ aspect: a11y Concerns related to the project's accessibility 🧰 goal: internal improvement Improvement that benefits maintainers, not users labels Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
♿️ aspect: a11y Concerns related to the project's accessibility 🧰 goal: internal improvement Improvement that benefits maintainers, not users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants