-
Notifications
You must be signed in to change notification settings - Fork 54
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
view_count
is also a non-nullable field in media. The sample data for images (in openverse-api
) contains a view_count
column with all values set to zero, can this be reproduced for audio?
@@ -73,7 +73,7 @@ | |||
name='category', required=False, size=80, truncate=False, | |||
), | |||
columns.JSONColumn( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a string array column. In PostgreSQL they are represented by varchar(<len>)[]
and the data can be stringified as {<item 1>,<item 2>...}
.
The current implementation of genres
is varchar(80)[]
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working on this, it's needed to add the new column type.
b0f3d3f
to
2bdb6ec
Compare
2bdb6ec
to
9895bf2
Compare
I'm not sure how |
If it's no longer used, should/can we remove it from the API models and sample data as well? I think it's best to remove fields that are no longer used, but we should loop in @obulat and @zackkrida for their opinions on this. |
27c1ca4
to
182e159
Compare
This is ready for review, can be tested with an audio API provider script, like Jamendo, and should load the audio table with the columns changed. For example, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 (We can remove the view_count
s in a separate PR later on)
In line with WordPress/openverse-api#141, this PR:
watermarked
column to the schema of the audio table in SQL filesgenre
column togenres
and changes its type to a Postgres array fieldalt_audio_files
column toalt_files
standardized_popularity
column forimage
andaudio
tables.