Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AudioStore development (original #322) #1752

Closed
obulat opened this issue Apr 21, 2021 · 1 comment
Closed

AudioStore development (original #322) #1752

obulat opened this issue Apr 21, 2021 · 1 comment

Comments

@obulat
Copy link
Contributor

obulat commented Apr 21, 2021

This issue has been migrated from the CC Search Catalog repository

Author: mariuszskon
Date: Fri Mar 13 2020
Labels: 🙅 status: discontinued

As per WordPress/openverse-catalog#311, integrating audio into CC Catalog will require a few different things. This issue hopes to keep track of everything relevant to the development of AudioStore.

(NEW) means a field that was not in ImageStore that was added to AudioStore
Current schema (in audio.py):

  • Foreign ID
  • Landing URL
  • Audio URL
  • File format (NEW)
  • Thumbnail URL
  • Filesize
  • Duration (NEW)
  • Samplerate (NEW)
  • Bitdepth (NEW)
  • Channels (NEW)
  • License (like ImageStore, license and license version)
  • Creator
  • Creator URL
  • Title
  • Collection/Album (NEW)
  • Type (music, podcast, lecture) (NEW)
  • Genre (NEW)
  • Language (NEW)
  • Metadata
  • Tags
  • Provider
  • Source

Other data to keep, but inside metadata rather than dedicated columns:

  • Date of publishing
  • Instruments
  • Mood
  • Description
  • Bitrate (as provided by source, rather than calculating ourselves from samplerate and bitdepth)
  • Views
  • Number of ratings
  • Numbers of comments
  • Related (list of foreign IDs of sounds which source considers to be similar)

Inappropriate columns for AudioStore that are in ImageStore:

  • Width
  • Height
  • Watermarked

Original Comments:

Issue author mariuszskon commented on Fri Mar 13 2020:

I am uncertain about the "type" field (as in music, podcast, lecture) and if it could be combined with genre in some way, or if we should keep it separate. What do you think @mathemancer ?
source

Issue author mariuszskon commented on Fri Mar 13 2020:

Date field blocked by WordPress/openverse-catalog#324
source

mathemancer commented on Mon Mar 16 2020:

@mariuszskon I think Genre and Type are different. We could probably come up with a list of 'allowed' types, e.g., music, podcast, lecture. Then, within music, we'd have the genres: rock, pop, classical, jazz, etc. On the other hand, in the 'podcast' type, for genre, we'd have: 'science', 'comedy', 'news', etc.
source

mathemancer commented on Mon Mar 16 2020:

@brenoferreira Do you have any guidance or ideas based on what you'd like to have available to the front end here?
source

brenoferreira commented on Mon Mar 16 2020:

Based on some of the designs here, it seems very comprehensive to me.
The frontend probably won't look exactly like this, but it'll probably be inspired by it. The only thing missing from the metadata list here are things like music instruments and mood. But I think that's ok
source

Issue author mariuszskon commented on Tue Mar 17 2020:

@mathemancer Indeed I see the distinction much more clearly, and it is certainly worth having them separate.
source

Issue author mariuszskon commented on Tue Mar 17 2020:

@brenoferreira instruments and mood can be added no problem, but I am concerned that audio sources might not have this information available for ingestion.
source

brenoferreira commented on Tue Mar 17 2020:

yes. that's what I meant. If the source has the info, great. But if not, it
should be fine for now

On Mon, Mar 16, 2020 at 11:33 PM Mariusz Skoneczko [email protected]
wrote:

@brenoferreira https://github.com/brenoferreira instruments and mood
can be added no problem, but I am concerned that audio sources might not
have this information available for ingestion.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
cc-archive/cccatalog#322 (comment),
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFMTSYST7AKUKEJPCGGO4LRH3ON7ANCNFSM4LG32CIQ
.

--
Thank you

Breno Ferreira
Front-end Engineer
Creative Commons

source

@zackkrida
Copy link
Member

I think this is ready to close! See WordPress/openverse-catalog#130 and WordPress/openverse-catalog#123

If anyone sees a reason to reopen, please do

@obulat obulat transferred this issue from WordPress/openverse-catalog Apr 17, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Openverse Backlog Apr 17, 2023
@obulat obulat moved this from 📋 Backlog to ✅ Done in Openverse Backlog Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants