This repository has been archived by the owner on Aug 4, 2023. It is now read-only.
Add missing watermarked column to audio loading table
#125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olga Bulat <[email protected]>
zackkrida
approved these changes
Jul 7, 2021
zackkrida
added
the
✨ goal: improvement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Audio table did not have
watermarkedfield at first. @krysal pointed out to me in a PR review that we have it in the API, and should have it in the catalog, as well. I added it to theAudioStorageand to loader sql scripts, but forgot to add it to the sql script that creates the intermediary loading table. This PR fixes this.This PR is also another reason why we should abstract the database column creation and writing code so that we can add a column in one place, and it updates everywhere. Instead of having to add a column to more than three places.
Signed-off-by: Olga Bulat [email protected]