This repository has been archived by the owner on Aug 4, 2023. It is now read-only.
Add a PR template to the repository #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obulat
approved these changes
Aug 2, 2021
krysal
reviewed
Aug 2, 2021
Comment on lines
+12
to
+13
| ## Tests | ||
| <!-- Give steps for the reviewer to verify that this PR fixes the problem; or delete this section entirely. --> |
There was a problem hiding this comment.
Thinking again about this section, I consider it important so I'd prefer that contributors don't skip it.
Suggested change
| ## Tests | |
| <!-- Give steps for the reviewer to verify that this PR fixes the problem; or delete this section entirely. --> | |
| ## Tests | |
| <!-- Give steps for the reviewer to verify that this PR fixes the problem. --> |
There was a problem hiding this comment.
It's generally much easier to deduce if a PR works by seeing the issue it addresses.
- If the PR fixes a bug, you can follow its steps to reproduce and they'll not reproduce the issue with the PR applied.
- If the PR adds a feature, we can check if the feature is added.
This section would only be useful in certain edge case scenarios or when an issue does not exist (which generally would be the case when a maintainer makes a PR).
zackkrida
approved these changes
Aug 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targets WordPress/openverse#35
This PR adds a PR template to the repository.