Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the logo to the readme 😄 #45

Merged
merged 4 commits into from
Aug 12, 2021
Merged

Add the logo to the readme 😄 #45

merged 4 commits into from
Aug 12, 2021

Conversation

zackkrida
Copy link
Member

Why not?

@zackkrida zackkrida requested a review from a team as a code owner August 12, 2021 01:02
@zackkrida zackkrida requested review from krysal and dhruvkb August 12, 2021 01:02
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks really good! We should add it uniformly to all the repos.

It's not very legible on a dark theme, though.
Screenshot 2021-08-12 at 8 10 18 AM


We can do something like Automattic/gutenberg-desktop where it's a full-width banner with a fixed background.
Screenshot 2021-08-12 at 8 12 23 AM

Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After merging #46, let's try it once with this change?

README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see our logo everywhere. Thank you for considering all color themes, @dhruvkb !

zackkrida and others added 2 commits August 12, 2021 07:13
Add banner asset with BG color to be independent of GitHub theme
Co-authored-by: Dhruv Bhanushali <[email protected]>
@zackkrida
Copy link
Member Author

Looks great with the yellow-bg banner, awesome improvement @dhruvkb

@zackkrida zackkrida merged commit 1f79d3e into main Aug 12, 2021
@zackkrida zackkrida deleted the readme-logo branch August 12, 2021 11:15
@zackkrida zackkrida mentioned this pull request Aug 14, 2021
dhruvkb pushed a commit that referenced this pull request Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants