Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include CODEOWNERS file in repo sync #48

Merged
merged 1 commit into from
Aug 13, 2021
Merged

Include CODEOWNERS file in repo sync #48

merged 1 commit into from
Aug 13, 2021

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Aug 12, 2021

Description

Since all repos have the same owners, it would be good to synchronise the CODEOWNERS file from a central location as well.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb requested a review from a team as a code owner August 12, 2021 23:28
@dhruvkb dhruvkb requested review from zackkrida and krysal August 12, 2021 23:28
@zackkrida
Copy link
Member

zackkrida commented Aug 12, 2021

I'd LOVE to do this with Flake8 and Prettier too. So cool. We could just assume every project uses python and JS. I guess the tricky thing is if these files could reliably be in the repo root or if they'd need to be in (inconsistent) subfolders.

@dhruvkb
Copy link
Member Author

dhruvkb commented Aug 13, 2021

Since the action doesn't really change anything (the files are already in sync), I'll just merge this without the second review.

@dhruvkb dhruvkb merged commit d4ed20c into main Aug 13, 2021
@dhruvkb dhruvkb deleted the codeowners_sync branch August 13, 2021 00:53
@zackkrida zackkrida mentioned this pull request Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants