Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[Feature] Add image width and height to the API response #156

Closed
1 task
obulat opened this issue Aug 3, 2021 · 2 comments
Closed
1 task

[Feature] Add image width and height to the API response #156

obulat opened this issue Aug 3, 2021 · 2 comments
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work

Comments

@obulat
Copy link
Contributor

obulat commented Aug 3, 2021

Problem

We have the information about image width and height in our database, however the API response does not include it.

Description

Adding image width and height information will help the frontend rendering.

Alternatives

Currently, the size is calculated after the images are loaded, which adds unnecessary calculations and causes additional layout shifts.

Additional context

Implementation

  • 🙋 I would be interested in implementing this feature.
@obulat obulat added 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository labels Aug 3, 2021
@dhruvkb
Copy link
Member

dhruvkb commented Aug 3, 2021

ImageSerializer already has height and width both serialised as IntergerFields.

@obulat
Copy link
Contributor Author

obulat commented Aug 9, 2021

I'm closing this issue as the problem is in the underlying data not having width and height, not API not sending them.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work
Projects
None yet
Development

No branches or pull requests

2 participants