Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version v10.21.0 RC #16036

Merged
merged 157 commits into from
Oct 29, 2022
Merged

Version v10.21.0 RC #16036

merged 157 commits into from
Oct 29, 2022

Conversation

metamaskbot
Copy link
Collaborator

📦 🚀

jpuri and others added 30 commits September 7, 2022 01:17
…15684)

* Updating storybook from 6.3 to 6.5

* Some lavamoat policy overrides for eslint
* adding custom component props to form-field component

* replacing ternary operater with binary logical OR

* Removing label from wrapping all form-field elements

* Adding wrapping label back but providing overriding props as well as updating default props
…15638)

* converted jazzicon component to functional and added story

* removed console statement

* updated appendChild with dangerouslySetInnerHtml

* added propType description

* replaced dangerouslySetHTML with appendChild

* updated useEffect to useCleanup
* ConfirmPage: update setApprovalForAll copy

* ConfirmPage: add TODO issue link
* warning for deprecated Rinkeby, Ropsten and Kovan test networks

* modified DeprecatedTestNetworks function

* added getCompletedOnboarding

* removed warning message from MetaMask ​​Notification page

* updated deprecatedTestNetworksMsg
* Convert Confirm Page Container test to tlr.

Add test ids to associated components.

* Convert Welcome component to tlr.

* Update ui/pages/first-time-flow/welcome/welcome.test.js

Co-authored-by: Ariella Vu <[email protected]>

* Update ui/components/app/confirm-page-container/confirm-page-container-container.test.js

Co-authored-by: Ariella Vu <[email protected]>

* Remove unsused, commented out, lines

Co-authored-by: Ariella Vu <[email protected]>
…ll to the bottom (#15788)

* fix issue wherein signing a message sometimes doesn't allow you to scroll all the way to the bottom

done in a way to make it as mergeable as possible

* Fixing length-zero-no-unit lint issue

Co-authored-by: ryanml <[email protected]>
Resolve an inconsistency between Chrome and Firefox with how the
contentscript runs in an iframe.

This should have no user-facing impact, it's just meant as a safeguard
in case something unintentionally gets included in the contentscript.
* Fix crash when uninstalling snap

* Run lint
* Updating Chromedriver to the last version

* Update Chrome version to last stable v105
* reset.scss: add comment

* reset.scss: revive <b> element font-weight

* scss: rm unused b {} style

* scss: rm .text b style

Co-authored-by: ryanml <[email protected]>
* MV3: migrate host_permissions

* MV3: alphabetize permissions

* rm superfluous permissions
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Brad Decker <[email protected]>
jpuri and others added 12 commits October 27, 2022 20:27
* [email protected]

* Update LavaMoat policies

* Fix eth_accounts permission for Snaps

* Update iframe execution environment

* Dedupe yarn.lock and rerun LavaMoat policy gen

* Add policy override for nanoid
* Fix inputs that should allow decimals

* Update e2e test to cover inputting of decimals in advanced fields

* Update e2e test to cover inputting of decimals in advanced fields

* Fix e2e tests
* Updating controller dependency

* fix

* fix

* fix

* fix

* fixes

* Lavamoat auto

* Update URLs for phishing detection testcase

* update lavamoat files

* call phishingController.test synchronously again

* bump @metamask/controllers to v32.0.1

* lint

* update policy files

* bump controllers version again

* modify update phishing list strategy

* revert back to use isOutOfDate, but without blocking substream

* possible way to fix e2e tests?

* enable testing

* Remove promise return from setupController in background.js, as it is no longer used

* Ensure updatePhishingLists is called in MM contrller constructer, so that phishing lists are updated right away

Co-authored-by: seaona <[email protected]>
Co-authored-by: Alex <[email protected]>
Co-authored-by: Dan Miller <[email protected]>
#16102)

* Remove ETH badge from NetworkAccountBalanceHeader when on non-ETH networks

* Network specific icons, or fallback, in the network-account-balance-header

* Update snapshots

* Code cleanup

Co-authored-by: Dan Miller <[email protected]>
* Enable "Add Popular Network" feature by default

* Fixing e2e tests

* Attempt to fix e2e tests

* Revert "Attempt to fix e2e tests"

This reverts commit d88e894.

* Get e2e tests passing

Co-authored-by: Dan J Miller <[email protected]>
* Last changelog updates with recently added PRs

* Remove snaps-skunkworks from Changelog

Co-authored-by: Frederik Bolding <[email protected]>

* Fix snaps issue that request eth_accounts permission

Co-authored-by: Frederik Bolding <[email protected]>

* Move flask PR to fixed section

Co-authored-by: Frederik Bolding <[email protected]>
@socket-security
Copy link

socket-security bot commented Oct 27, 2022

Socket Security Report

👍 No new dependency issues detected in pull request

Socket.dev scan summary
Issue Status
Did you mean? ✅ no new possible package typos
Install scripts ✅ no new install scripts
Telemetry ✅ no new telemetry
Troll package ✅ no new troll packages
Malware ✅ no new malware
Native code ✅ no new native modules
Bin Script Confusion ✅ no new bin script confusions
Bin script shell injection ✅ no new bin script shell injection
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] [email protected]

Ignoring: @ethereumjs/[email protected], [email protected], [email protected]

Powered by socket.dev

@seaona seaona marked this pull request as ready for review October 28, 2022 09:46
@seaona seaona requested review from a team and kumavis as code owners October 28, 2022 09:46
@metamaskbot
Copy link
Collaborator Author

Builds ready [3374718]
Page Load Metrics (2271 ± 51 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint882237210465223
domContentLoaded21102605225510952
load21352605227110551
domInteractive21102605225510952

highlights:

storybook

@Gudahtt
Copy link
Member

Gudahtt commented Oct 28, 2022

@SocketSecurity ignore @ethereumjs/[email protected] [email protected] [email protected]

We don't use the bin script for these packages, so it doesn't really matter that they overlap.

@danjm danjm merged commit 0aa3e4f into master Oct 29, 2022
@danjm danjm deleted the Version-v10.21.0 branch October 29, 2022 00:44
@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2022
@Gudahtt Gudahtt restored the Version-v10.21.0 branch October 29, 2022 00:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.