Expand error details before taking screenshot when a test fails with a Page Error

[seaona]

Explanation

When the e2e tests fail, a screenshot is taken and uploaded as Artifacts in circle ci. The problem is that when we reach an error page, the Error details are hiden and the screenshot does not captures valuable info.

For improving this behaviour, we now check if we reach a Page error and we expand the error details before taking the screenshot.

• Closes Add step for expanding Error when failed test #15511

Screenshots/Screencaps

Before

Artifacts screenshot with Page Errors looked like:

After

Now, Error is expanded and screenshot looks like:

Manual Testing Steps

For testing this manually, you can trigger the Page error during a test (this will make it fail) and check that the screenshot is taken after page details are expanded.

1. Pick any e2e test and add a delay, so you have a bit of time to perform step 2: await driver.delay(3000)
2. Change the URL to home.html#settings/contact-list/view-contact/
3. Wait until test fails

See test effectively expands the error details and screenshot is taken after this step.

Pre-Merge Checklist

• PR template is filled out
• IF this PR fixes a bug, a test that would have caught the bug has been added
• PR is linked to the appropriate GitHub issue
• PR has been added to the appropriate release Milestone

+ If there are functional changes:

• Manual testing complete & passed
• "Extension QA Board" label has been applied

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [74933a4]

• builds: chrome, firefox, opera
• builds (beta): chrome, firefox, opera
• builds (flask): chrome, firefox, opera
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 2, 3, 4, 5, 6, 7
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1953 ± 81 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	101	1685	211	339	163
		domContentLoaded	1684	2402	1935	162	78
		load	1684	2403	1953	168	81
		domInteractive	1684	2402	1935	162	78